Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run first command of wapm file and print all commands instead #3402

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Do not run first command of wapm file and print all commands instead #3402

merged 2 commits into from
Dec 2, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Dec 2, 2022

Fixes #3345.

@fschutt
Copy link
Contributor Author

fschutt commented Dec 2, 2022 •
edited
Loading 

./target/release/wasmer wasmer/wabt
error: The `wasmer/[email protected]` package doesn't have a default entrypoint, but has multiple available commands:
│   1: You can run any of those by using the --command-name=COMMAND flag or : postfix
│   2: `wat2wasm`, `wast2json`, `wasm2wat`, `wasm-interp`, `wasm-validate`, `wasm-strip`
╰─▶ 3:   -> wasmer run wasmer/[email protected] --command-name=wat2wasm OR wasmer run wasmer/[email protected]:wat2wasm

Not sure if we desperately need an integration test for this @syrusakbary

@fschutt
Copy link
Contributor Author

fschutt commented Dec 2, 2022

bors r+

bors bot added a commit that referenced this pull request Dec 2, 2022
@bors @fschutt
Merge #3402
b789773 
3402: Do not run first command of wapm file and print all commands instead r=fschutt a=fschutt

Fixes #3345.

Co-authored-by: Felix Schütt <[email protected]>
@bors
Copy link
Contributor

bors bot commented Dec 2, 2022

Canceled.

@fschutt
Copy link
Contributor Author

fschutt commented Dec 2, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 2, 2022

Build succeeded:

@bors bors bot merged commit 01daa24 into master Dec 2, 2022
@bors bors bot deleted the fix-3345 branch December 2, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasmer wasmer/wabt not working as expected (multiple commands)
2 participants
@fschutt @Michael-F-Bryan