Restore Support For All Wasi Clock Types #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables support for the wasi process and thread time clock types (2 and 3). These were already implemented, but not correctly wired up due to a duplication of the Clockid type. This commit switches to using the correct Snapshot0Clockid everywhere. In the future the "enum Clockid" should be removed, but that was not done in this commit because currently the ./regenerate.sh script is broken.
theduke
force-pushed
the
fix-issue-3384-wasi-clockids
branch
from
3ff07d3 to
3bb1871
Compare
syrusakbary
approved these changes
Nov 29, 2022
fschutt
approved these changes
Nov 30, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables support for the wasi process and thread time clock types (2 and 3).
These were already implemented, but not correctly wired up due to a
duplication of the Clockid type.
This commit switches to using the correct Snapshot0Clockid everywhere.
In the future the "enum Clockid" should be removed, but that was not
done in this commit because currently the ./regenerate.sh script is
broken.
Closes #3384 .