Fetch the pirita download URL #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
Nov 22, 2022
| @@ -317,6 +318,7 @@ pub fn query_command_from_registry( | |||
| let package = command.package_version.package.display_name; | |||
| let version = command.package_version.version; | |||
| let url = command.package_version.distribution.download_url; | |||
| let pirita_url = command.package_version.distribution.pirita_download_url; | |||
|
|
|||
| Ok(PackageDownloadInfo { | |||
There was a problem hiding this comment.
Why don't we return the type/content from command.package_version. That seems way easier than recreating a new struct each time
There was a problem hiding this comment.
I'll approve in any case, we can revisit this after
There was a problem hiding this comment.
Yeah, you have a good point.
Something we should do is make all our GraphQL queries public. That way people can execute them directly if a high-level function (e.g. wasmer_registry::query_command_from_registry()) doesn't support exactly what you are looking for.
syrusakbary
approved these changes
Nov 23, 2022
|
bors r+ |
Merged
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Nov 23, 2022
3360: Introduce a "wasmer_registry::queries" module with all GraphQL queries r=fschutt a=Michael-F-Bryan This makes all queries used in the `wasmer-registry` crate public. See #3355 (comment) for some more context. Co-authored-by: Michael-F-Bryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some more queries to the
wasmer-registrycrate.I've also had to remove
lib/wasi-types/wit-bindgenbecause it's a broken link to usewai-bindgenfrom crates.io, otherwise you get the following error when trying to usewasmerio/wasmeras a git dependency (I had to temporarily patch mywasmer-registryfrom crates.io in https://github.com/wasmerio/pirita/pull/62 to see if this PR would work).