Bump the MSRV to 1.63 #3318
Merged
Bump the MSRV to 1.63 #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
bump-msrv
branch
from
91737c7 to
ef80c51
Compare
ptitSeb
reviewed
Nov 17, 2022
| - [#2948](https://github.com/wasmerio/wasmer/pull/2948) Fix regression on gen_import_call_trampoline_arm64() | ||
| - [#2944](https://github.com/wasmerio/wasmer/pull/2944) Fix duplicate entries in the CHANGELOG | ||
| - [#2944](https://github.com/wasmerio/wasmer/pull/2944) Fix duplicate entries in the CHANGELOG | ||
|
|
There was a problem hiding this comment.
The hunt of the trailling space :P !
ptitSeb
reviewed
Nov 17, 2022
| write!(f, "host(")?; | ||
| p.as_ref().fmt(f)?; | ||
| write!(f, ")") | ||
| } | ||
| MaybeInstanceOwned::Instance(p) => { | ||
| Self::Instance(p) => { | ||
| write!(f, "instance(")?; | ||
| unsafe { p.as_ref().fmt(f)? }; | ||
| write!(f, ")") |
There was a problem hiding this comment.
I always forgot to fix thoses one. It's done now, good.
ptitSeb
reviewed
Nov 17, 2022
tests/compilers/typed_functions.rs
Outdated
| @@ -244,11 +244,11 @@ fn static_host_function_without_env(config: crate::Config) -> anyhow::Result<()> | |||
| let mut store = config.store(); | |||
|
|
|||
| fn f(a: i32, b: i64, c: f32, d: f64) -> (f64, f32, i64, i32) { | |||
| (d * 4.0, c * 3.0, b * 2, a * 1) | |||
| (d * 4.0, c * 3.0, b * 2, a) | |||
| } | |||
There was a problem hiding this comment.
Not a fan of the "* 1" removal, as it was here for clarity. Still works, but, meh
There was a problem hiding this comment.
Yeah, it looks like clippy warns you about redundant multiplies so clippy --fix will "help" out by removing them 😞
ptitSeb
approved these changes
Nov 17, 2022
Michael-F-Bryan
force-pushed
the
bump-msrv
branch
from
ef80c51 to
e3ea8b4
Compare
Michael-F-Bryan
force-pushed
the
bump-msrv
branch
from
e3ea8b4 to
3a092cf
Compare
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upgraded our dependencies as part of #3254 (9b13fae), which pulled in version
1.2.0of thederive_arbitrarycrate. This requires Rust1.63to compile, but our current minimum supported Rust version is1.61.This PR bumps our MSRV to match that of
derive_arbitrary.Review