Some Refactor of Singlepass compiler to have better error and cpu features handling #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
Nov 14, 2022
syrusakbary
approved these changes
Nov 14, 2022
|
I gave it a quick pass, but I don't have anything valuable to add. |
theduke
approved these changes
Nov 15, 2022
|
bors r+ |
|
Build succeeded:
|
ptitSeb
added a commit
that referenced
this pull request
Nov 23, 2022
bors bot
added a commit
that referenced
this pull request
Nov 24, 2022
3364: Added the actual LZCNT / TZCNT implementation r=ptitSeb a=ptitSeb # Description The actual implementation of LZCNT and TZCNT for the x86_64 Singlepass backend. Somehow, it was missing from #3302 Co-authored-by: ptitSeb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Backport Singlepass optimisations from Near #3305