Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validate subcommand #323

Merged
merged 3 commits into from
Apr 4, 2019
Merged

add validate subcommand #323

merged 3 commits into from
Apr 4, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

No description provided.

@MarkMcCaskey MarkMcCaskey added the 🎉 enhancement New feature! label Apr 3, 2019
@MarkMcCaskey MarkMcCaskey requested a review from syrusakbary April 3, 2019 23:53
@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Apr 3, 2019
@bors
Merge #323
095c776 
323: add validate subcommand r=syrusakbary a=MarkMcCaskey



Co-authored-by: Mark McCaskey <[email protected]>
bjfish
bjfish reviewed Apr 4, 2019
View reviewed changes
src/bin/wasmer.rs Outdated
));
}

wabt::Module::read_binary(wasm_binary, &Default::default())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime has a validate method:

wasmer/lib/runtime/src/lib.rs

Line 87 in bf823d2

pub use wasmer_runtime_core::{compile_with, validate};

It may be lighterweight solution than wabt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think we'd want better error messages than yes or no, I'll look in to the functions that that validate fn calls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out!

@MarkMcCaskey
Copy link
Contributor Author

bors r-

@bors
Copy link
Contributor

bors bot commented Apr 4, 2019

Canceled

@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 4, 2019

Merge conflict

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 4, 2019
@bors @MarkMcCaskey
Merge #323
1ac689c 
323: add validate subcommand r=MarkMcCaskey a=MarkMcCaskey



Co-authored-by: Mark McCaskey <[email protected]>
Co-authored-by: Mark McCaskey <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 4, 2019

Build succeeded

@bors bors bot merged commit 03b529d into master Apr 4, 2019
@bors bors bot deleted the add-validate branch April 4, 2019 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@bjfish bjfish bjfish approved these changes

Assignees
No one assigned
Labels
🎉 enhancement New feature!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkMcCaskey @syrusakbary @bjfish