Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial port of make test-js-core (port wasmer API to core) #3165

Merged
merged 8 commits into from
Sep 2, 2022
Merged

Initial port of make test-js-core (port wasmer API to core) #3165

merged 8 commits into from
Sep 2, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Aug 31, 2022

Fixes #3151.

@fschutt fschutt requested a review from syrusakbary as a code owner August 31, 2022 13:43
syrusakbary
syrusakbary approved these changes Sep 2, 2022
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once tests pass and comments are addressed!

syrusakbary
syrusakbary reviewed Sep 2, 2022
View reviewed changes
Makefile Show resolved Hide resolved
@fschutt
Copy link
Contributor Author

fschutt commented Sep 2, 2022

@syrusakbary can be merged now

@syrusakbary syrusakbary merged commit aedbdcc into master Sep 2, 2022
@bors bors bot deleted the make-wasmer-js-work-on-core branch September 2, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make wasmer-js work with core
2 participants
@fschutt @syrusakbary