Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C-API: add functions to overwrite stdin / stdout / stderr handlers #3145

Merged
merged 80 commits into from
Oct 17, 2022
Merged

C-API: add functions to overwrite stdin / stdout / stderr handlers #3145

merged 80 commits into from
Oct 17, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Aug 30, 2022

Fixes #2334

Continuation of PR #3032.

Adds a C-API for overwriting stdin / stdout / stderr and make them useable via pipes without depending on I/O or user input.

epilys and others added 30 commits August 5, 2022 12:35
@epilys @fschutt
c-api: add functions to overwrite stdin and to write to it
f3fc438 
Fixes #2334
@fschutt
Refactor overriding stdin / stdout / stderr into wasi_console_io_over…
b1c77a1 
…ride_t
@fschutt
Add (non-working) unit test
759b2f6
@fschutt
Remove wasi_env_write_stdin
8e5ff7d
@fschutt
Fix C API
dccaa3f
@fschutt
Make capi unit test functional, finalize C API
d0ccb34
@fschutt
Fix double free() in deallocation of WasiConsoleMemoryOverride
660f866
@fschutt
Rename "wasi_console_io_override_t" to "wasi_console_out_t"
127e06d
@fschutt
Added API for wasi_stdin_t
5103306
@fschutt
Finalize API for stdin API rewrite
8c36f06
@fschutt
Try debuggint unit test test_wasi_stdin_set
dfe4e8e
@fschutt
Fixed stdin-capi unit test not running due to missing imports
f4ff4bc
@fschutt
Fix C-API stdin PR: read correct amount of bytes and fix stdout cursor
5e83b80
@fschutt
cargo fmt
ed4fb72
@fschutt
Fix __u_long to size_t in C API
aa27a66
@fschutt
Change size_t to unsigned long
2ff8d34
@fschutt
Use int64_t / uintptr_t
1224700
@fschutt
cargo update
f1a3350
@fschutt
Fix clippy errors in lib/c-api/src/wasm_c_api/wasi/mod.rs
ac127d8
@fschutt
Merge branch 'master' into capi-wasi-overwrite-stdin
18709f2
@fschutt
Use wasi::Pipe
838d932
@fschutt
First work to translate from WasiConsoleMemoryOverride to Pipe
df05679
@fschutt
Implement console_io_memory using wasi::Pipe
662be61
@fschutt
Merge branch 'master' into capi-wasi-overwrite-stdin
9c4bc82
@fschutt
Address review changes
16f7ff7
@fschutt
Fix errors in make test-capi
b7f30c9
@fschutt
Merge branch 'master' into capi-wasi-overwrite-stdin
a93f589
@fschutt
cargo fmt && make lint
6e944fa
@fschutt
Adress review comment: rename wasi_console_out_new -> wasi_pipe_new
63d709e
@fschutt
Merge branch 'master' into capi-wasi-overwrite-stdin-3
61ff302
This was referenced Oct 5, 2022
Closed
Closed
@fschutt
Copy link
Contributor Author

fschutt commented Oct 11, 2022

john: just one thing left - the bytes_available methods are meant to be implemented and not just return Ok(())

@fschutt fschutt force-pushed the capi-wasi-overwrite-stdin-3 branch from 0d622ec to 05d74ea Compare October 17, 2022 12:10
syrusakbary
syrusakbary approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: approved on behalf of @john-sharratt

@syrusakbary syrusakbary merged commit e1e08f4 into master Oct 17, 2022
@bors bors bot deleted the capi-wasi-overwrite-stdin-3 branch October 17, 2022 14:07
@fschutt fschutt mentioned this pull request Oct 19, 2022
Closed
syrusakbary added a commit that referenced this pull request Nov 21, 2022
@syrusakbary
Revert #3145
0a1a71f 
This reverst buggy commit e1e08f4
@syrusakbary syrusakbary mentioned this pull request Nov 21, 2022
Merged
@fschutt fschutt mentioned this pull request Nov 21, 2022
Closed
bors bot added a commit that referenced this pull request Nov 23, 2022
@bors @syrusakbary @fschutt
Merge #3344
f247db8 
3344: Revert #3145 r=fschutt a=syrusakbary

This reverts buggy commit e1e08f4 merging #3145 

Co-authored-by: Syrus Akbary <[email protected]>
Co-authored-by: Felix Schütt <[email protected]>
Co-authored-by: Felix Schütt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@john-sharratt john-sharratt Awaiting requested review from john-sharratt

@Michael-F-Bryan Michael-F-Bryan Awaiting requested review from Michael-F-Bryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[c-api] add more functions for stdin/stderr/stdout control
4 participants
@fschutt @john-sharratt @syrusakbary @epilys