New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The API breaking changes from future WASIX/Network/Threading addition #3141

Merged

syrusakbary merged 6 commits into master from feat_api_change_from_wasix

Sep 2, 2022

Contributor

ptitSeb commented Aug 26, 2022

Description

Some API Changes to prepare for future WASIX/Network/MultiThreading changes.


          The API breaking changes from future WASIX/Network/Threading addition

ptitSeb requested a review from syrusakbary as a code owner

August 26, 2022 08:48

ptitSeb requested a review from john-sharratt

August 26, 2022 08:48

ptitSeb added 2 commits

September 1, 2022 11:17


          Merge branch 'master' into feat_api_change_from_wasix

553d6bb


          Using IntoBytes only for Module::deserialise (both sys and js)

436bec7

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Outdated Show resolved Hide resolved

syrusakbary requested changes

View reviewed changes

Member

syrusakbary left a comment

We are missing two things:

Module::serialize should return Result<Bytes, SerializeError>.
Module.raw_bytes should be stored as Option<Bytes> instead of Option<Vec<u8>>

syrusakbary reviewed

View reviewed changes

lib/api/src/sys/module.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

lib/api/src/sys/module.rs Outdated Show resolved Hide resolved


          Made Module::serialize to gives Bytes instead of Vec

ptitSeb requested a review from syrusakbary

September 1, 2022 15:19

syrusakbary reviewed

View reviewed changes

lib/api/src/js/module.rs Outdated Show resolved Hide resolved


          Fixed js build

cc9fb46

syrusakbary reviewed

View reviewed changes

lib/api/src/lib.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

tests/compilers/imports.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

tests/compilers/imports.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

tests/compilers/imports.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

tests/lib/wast/src/wasi_wast.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

tests/compilers/traps.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

tests/compilers/traps.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

tests/compilers/traps.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

tests/compilers/traps.rs Outdated Show resolved Hide resolved

syrusakbary reviewed

View reviewed changes

tests/compilers/traps.rs Outdated Show resolved Hide resolved


          More rollback fixes

2752f7d

ptitSeb requested a review from syrusakbary

September 1, 2022 16:09

syrusakbary approved these changes

View reviewed changes

syrusakbary merged commit e259738 into master

bors bot deleted the feat_api_change_from_wasix branch

September 2, 2022 05:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet