Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(llvm-backend) Clean up various warnings #310

Merged
merged 13 commits into from
Apr 1, 2019
Merged

fix(llvm-backend) Clean up various warnings #310

merged 13 commits into from
Apr 1, 2019

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Mar 29, 2019

These patches remove various warnings raised by rustc.
Only 2 warnings remain.

Hywan added 12 commits March 29, 2019 10:03
@Hywan
fix(llvm-backend) Remove unused imports.
a1ca706
@Hywan
fix(llvm-back) Mark WasmTrapType as deadcode.
91f4063 
This enum is not used directly by Rust, but used externally.
@Hywan
fix(llvm-backend) LLVMBackend::new doesn't use instrinsics yet.
dea4705
@Hywan
fix(llvm-backend) parse_function doesn't need a Module.
e3f39fc
@Hywan
fix(llvm-backend) llvm_sig variable is not used here.
20378de
@Hywan
fix(llvm-backend) No need to enumerate items in this iterator.
00e4b25
@Hywan
fix(llvm-backend) Remove unused variables.
7645a81
@Hywan
fix(llvm-backend) Remove Intrinsics.ctx_ty, CtxType.ctx_ty, and .…
76d26d9 
…ctx_ptr_ty`.
@Hywan
fix(llvm-backend) Remove unused variables or functions.
b03980f
@Hywan
fix(llvm-backend) Mark a variable as unused.
5cd45cb
@Hywan
fix(llvm-backend) Mark some variables as unused.
34b4f2f
@Hywan
fix(llvm-backend) Remove sign_type from generate_trampoline.
8179dd6
@Hywan Hywan added 🎉 enhancement New feature! 📦 lib-compiler-llvm About wasmer-compiler-llvm labels Mar 29, 2019
@Hywan Hywan requested a review from lachlansneff March 29, 2019 09:11
@xmclark xmclark self-requested a review March 31, 2019 01:11
@xmclark
Copy link
Contributor

xmclark commented Mar 31, 2019

bors try

bors bot added a commit that referenced this pull request Mar 31, 2019
@bors
Try #310:
aa1ef92
@bors
Copy link
Contributor

bors bot commented Mar 31, 2019

try

Build succeeded

xmclark
xmclark approved these changes Mar 31, 2019
View reviewed changes
Copy link
Contributor

@xmclark xmclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these warnings! Ready to merge.

@Hywan
Copy link
Contributor Author

Hywan commented Apr 1, 2019

bors r+

bors bot added a commit that referenced this pull request Apr 1, 2019
@bors @Hywan @xmclark
Merge #310
593720d 
310: fix(llvm-lint) Clean up various warnings r=Hywan a=Hywan

These patches remove various warnings raised by `rustc`.
Only 2 warnings remain.

Co-authored-by: Ivan Enderlin <[email protected]>
Co-authored-by: Mackenzie Clark <[email protected]>
@Hywan Hywan changed the title fix(llvm-lint) Clean up various warnings fix(llvm-backend) Clean up various warnings Apr 1, 2019
@bors
Copy link
Contributor

bors bot commented Apr 1, 2019

Build succeeded

@bors bors bot merged commit 124563a into wasmerio:master Apr 1, 2019
surban pushed a commit to rust-wasi-web/wwrr that referenced this pull request Nov 9, 2024
Merge pull request wasmerio#310 from wasmerio/fix-wasmer-js
89c1e4c 
Correctly downcast RuntimeError through JsValue when extracting WASI exit codes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmclark xmclark xmclark approved these changes

@lachlansneff lachlansneff Awaiting requested review from lachlansneff

Assignees
No one assigned
Labels
🎉 enhancement New feature! 📦 lib-compiler-llvm About wasmer-compiler-llvm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hywan @xmclark