Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native feature entry from docs.rs metadata #3069

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

silwol
Copy link
Contributor

@silwol silwol commented Aug 4, 2022

The native feature is no longer present, but was still in the list of
features to be enabled when building the documentation for docs.rs,
causing the build there to fail. Removal should re-enable the build of
the documentation for docs.rs.

Closes: #3066

The native feature is no longer present, but was still in the list of
features to be enabled when building the documentation for docs.rs,
causing the build there to fail. Removal should re-enable the build of
the documentation for docs.rs.

Closes: #3066
@silwol silwol requested a review from syrusakbary as a code owner August 4, 2022 06:22
Copy link
Contributor

@epilys epilys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good,

It'd also be a good idea to add a new commit adding these new features in the docs:

wasmer-artifact-load 
wasmer-artifact-create 
static-artifact-load 
static-artifact-create

@epilys epilys added this to the v3.0 milestone Aug 4, 2022
@silwol
Copy link
Contributor Author

silwol commented Aug 4, 2022

It'd also be a good idea to add a new commit adding these new features in the docs:

These reference the respective feature with the same name in wasmer-compiler, I assume it makes sense to enable them inside that crate as well, otherwise we might attempt reference types inside wasmer-compiler that are not rendered there.

@silwol
Copy link
Contributor Author

silwol commented Aug 4, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Aug 4, 2022

Build succeeded:

@bors bors bot merged commit b58128e into master Aug 4, 2022
@bors bors bot deleted the silwol/fix-wasmer-docs-build-on-docs.rs branch August 4, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for wasmer 3 fails to build for docs.rs
2 participants