Removed trailing zero in WASI::fd_prestat_dir_name name return (for #3025) #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Posix defines character strings as null terminated, personally I'd like all path strings that go out into a module to be null terminated. What do you think? |
|
I agree, but this is WASI here, not POSIX. check the ticket mentioned for more detail. Not sure the change should be done. But if we don't it, we should close the mentioned ticket as a "will not be done" |
syrusakbary
reviewed
Aug 3, 2022
syrusakbary
approved these changes
Aug 3, 2022
syrusakbary
approved these changes
Oct 5, 2022
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed trailing zero in WASI::fd_prestat_dir_name returned name (for #3025)