Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check-public-api.yaml workflow #3008

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Add check-public-api.yaml workflow #3008

merged 1 commit into from
Jul 21, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Jul 5, 2022

WIP PR: Adds a new CI check that uses cargo public-api to track changes in the API between master and the last deployed version on crates.io.

Fixes #2984

Review

  • Add a short description of the change to the CHANGELOG.md file

@fschutt fschutt marked this pull request as draft July 5, 2022 12:53
@fschutt fschutt force-pushed the ci-check-public-api branch from ba4e1ca to cb535c6 Compare July 5, 2022 13:46
@fschutt
Copy link
Contributor Author

fschutt commented Jul 5, 2022

@epilys I have no idea why this workflow doesn't run, works 1:1 for me on my local machine.

@fschutt fschutt force-pushed the ci-check-public-api branch from cb535c6 to 928827e Compare July 5, 2022 14:51
@fschutt fschutt marked this pull request as ready for review July 5, 2022 14:53
@fschutt
Copy link
Contributor Author

fschutt commented Jul 11, 2022

So the workflow runs now @epilys - https://github.com/wasmerio/wasmer/actions/runs/2649376904 contains the artifact containing the auto-generate API diff.

Now that this works, I'd change the workflow to only get triggered on vX.Y.Z release tags.

@fschutt fschutt changed the title WIP: Added check-public-api.yaml workflow Add check-public-api.yaml workflow Jul 12, 2022
.github/workflows/check-public-api.yaml Outdated Show resolved Hide resolved
.github/workflows/check-public-api.yaml Outdated Show resolved Hide resolved
.github/workflows/check-public-api.yaml Outdated Show resolved Hide resolved
.github/workflows/check-public-api.yaml Outdated Show resolved Hide resolved
@fschutt fschutt force-pushed the ci-check-public-api branch 2 times, most recently from 8458ea0 to 7aa5623 Compare July 13, 2022 11:50
@fschutt fschutt force-pushed the ci-check-public-api branch from 7aa5623 to c31e052 Compare July 21, 2022 09:31
Copy link
Contributor

@epilys epilys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@epilys epilys force-pushed the ci-check-public-api branch from c31e052 to b20e56e Compare July 21, 2022 10:19
The new check-public-api workflow checks outputs a diff as an artifact
between the current master and the latest deployed version of wasmer
on crates.io

Fixes #2984

Fetch entire history of git repo to generate public API diff

Only run diff-API workflow when releasing new versions

Trigger diff-api workflow only manually or on tags
@epilys epilys force-pushed the ci-check-public-api branch from b20e56e to b92d4bc Compare July 21, 2022 10:26
@epilys
Copy link
Contributor

epilys commented Jul 21, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 21, 2022

Build succeeded:

@bors bors bot merged commit 4d66e79 into master Jul 21, 2022
@bors bors bot deleted the ci-check-public-api branch July 21, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add manual CI action for public Rust API changes
2 participants