Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --invoke option for emscripten files without _start function #2999

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Jul 1, 2022

When running emscripten files, the CLI now supports the --invoke option to invoke a function by name.

Review

  • Add a short description of the change to the CHANGELOG.md file

lib/emscripten/src/lib.rs Outdated Show resolved Hide resolved
lib/emscripten/src/lib.rs Show resolved Hide resolved
@epilys
Copy link
Contributor

epilys commented Jul 1, 2022

@fschutt btw can you share the emscripten files you used for testing?

@fschutt
Copy link
Contributor Author

fschutt commented Jul 4, 2022

@epilys I tested it with the python-0.2.0.tar.gz

unpack python-0.0.2.tar.gz
wasmer run ./python-0.0.2.tar.gz/bin/python37.wasm
wasmer run --invoke _main ./python-0.0.2.tar.gz/bin/python37.wasm

python-0.0.2.tar.gz

I tested manually that it works (after all, it's just a single variable difference to the run() code). I'd want to avoid committing large files to git if possible.

@fschutt fschutt force-pushed the emscripten-nomain branch 2 times, most recently from 66a43f8 to 8c3c7ec Compare July 4, 2022 12:39
@fschutt fschutt requested a review from epilys July 4, 2022 14:19
@epilys epilys force-pushed the emscripten-nomain branch from d745baf to 2d4edee Compare July 12, 2022 08:41
@epilys
Copy link
Contributor

epilys commented Jul 12, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 12, 2022

Build succeeded:

@bors bors bot merged commit 7093d61 into master Jul 12, 2022
@bors bors bot deleted the emscripten-nomain branch July 12, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants