Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have make targets install-capi-lib,install-pkgconfig work without building the wasmer binary #2988

Conversation

epilys
Copy link
Contributor

@epilys epilys commented Jun 29, 2022

Description

  1. modified target install-capi-lib to detect version without requiring the binary being built.

  2. added separate install target for library: install-capi instead of using install for both binary and library

  3. added target install-capi-pkgconfig that outputs this example .pc file if the binary is missing:

    prefix=/usr/local
    includedir=${prefix}/include
    libdir=${prefix}/lib
    
    Name: wasmer
    Description: The Wasmer library for running WebAssembly
    Version: 2.3.0
    Cflags: -I${prefix}/include
    Libs: -L${prefix}/lib -lwasmer
    

Fixes #2541

Review

  • Add a short description of the change to the CHANGELOG.md file

@epilys epilys self-assigned this Jun 29, 2022
…lding binary

1. modified target `install-capi-lib` to detect version without requiring the binary being built.
2. added separate install target for library: `install-capi` instead of using `install` for both binary and library
3. added target `install-capi-pkgconfig` that outputs this example `.pc` file if the binary is missing:

   ```pc
   prefix=/usr/local
   includedir=${prefix}/include
   libdir=${prefix}/lib

   Name: wasmer
   Description: The Wasmer library for running WebAssembly
   Version: 2.3.0
   Cflags: -I${prefix}/include
   Libs: -L${prefix}/lib -lwasmer
   ```

Fixes #2541
@epilys epilys force-pushed the make-install-capi-lib-and-make-install-pkgconfig-fail-unless-wasmer-binary-is-built branch from 1ca5a05 to 62283b6 Compare June 29, 2022 20:03
@epilys epilys marked this pull request as ready for review June 29, 2022 20:03
@epilys
Copy link
Contributor Author

epilys commented Jun 29, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 29, 2022

Build succeeded:

@bors bors bot merged commit 14d8084 into master Jun 29, 2022
@bors bors bot deleted the make-install-capi-lib-and-make-install-pkgconfig-fail-unless-wasmer-binary-is-built branch June 29, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make install-capi-lib and make install-pkgconfig fail unless wasmer binary is built.
1 participant