Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade enumset minimum version to one that compiles #2976

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

palfrey
Copy link
Contributor

@palfrey palfrey commented Jun 26, 2022

Description

enumset dependency was on 1.0, but only 1.0.2 has a fix for compiling with newer syn. This PR fixes that, and adds a makefile target for testing the minimal version scenario. It probably really should be added to the CI, but not sure where in the complicated setup here!

Review

  • Add a short description of the change to the CHANGELOG.md file

@palfrey palfrey marked this pull request as ready for review June 26, 2022 22:27
@palfrey palfrey requested a review from syrusakbary as a code owner June 26, 2022 22:27
@epilys
Copy link
Contributor

epilys commented Jun 27, 2022

Hello and thank you for your PR!

Cargo actually chooses the latest patch version when you specify a dependency like that (i.e. 1.0) and indeed you can see at our Cargo.lock it actually uses 1.0.11. Have you had a problem with this dependency when using those crates on by themselves e.g. on crates.io?

@palfrey
Copy link
Contributor Author

palfrey commented Jun 27, 2022

The actual issue I'm trying to fix is swc-project/swc#5041 but I'm having to dig through all its dependencies with this issue first!

The cargo semver stuff does the right thing most of the time, but sometimes someone has set a really strict version requirement somewhere else (and is compatible with the lower version) and then your code here will fail because the version listed doesn't actually work.

I agree that this isn't a case that crops up most of the time, and hence the thinking around double checking this in CI.

@epilys epilys force-pushed the enumset-minimum branch from a501132 to 34aafad Compare June 29, 2022 17:32
@epilys
Copy link
Contributor

epilys commented Jun 29, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 29, 2022

Build succeeded:

@bors bors bot merged commit 711bfef into wasmerio:master Jun 29, 2022
@palfrey palfrey deleted the enumset-minimum branch June 29, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants