Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context api tests #2974

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Context api tests #2974

merged 2 commits into from
Jun 30, 2022

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Jun 24, 2022

Description

Migrate compiler tests and metering to the new Context API

@ptitSeb ptitSeb force-pushed the context_api_tests branch from d7da7ba to eda5fbb Compare June 24, 2022 15:36
@ptitSeb ptitSeb marked this pull request as ready for review June 28, 2022 13:05
@ptitSeb ptitSeb requested a review from epilys June 28, 2022 13:05
@ptitSeb ptitSeb force-pushed the context_api_tests branch from 92b7eb4 to 7433215 Compare June 28, 2022 13:31
epilys
epilys suggested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@epilys epilys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash fixes with previous commits

syrusakbary
syrusakbary requested changes Jun 29, 2022
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change all the calls to &mut ctx.as_context_mut() to &mut ctx (and from &ctx.as_context_ref() to &ctx, if any of this exists)

@ptitSeb ptitSeb force-pushed the context_api_tests branch from 3fb46b6 to e154f45 Compare June 29, 2022 07:44
@ptitSeb
Copy link
Contributor Author

ptitSeb commented Jun 29, 2022

Squash fixes with previous commits

Done

@ptitSeb
Copy link
Contributor Author

ptitSeb commented Jun 29, 2022

Let's change all the calls to &mut ctx.as_context_mut() to &mut ctx (and from &ctx.as_context_ref() to &ctx, if any of this exists)

Done

@ptitSeb ptitSeb requested review from epilys and syrusakbary June 29, 2022 15:14
@epilys epilys force-pushed the context_api_tests branch from f2ba42b to aa204b3 Compare June 30, 2022 13:08
@epilys epilys merged commit 512508e into context_api Jun 30, 2022
@bors bors bot deleted the context_api_tests branch June 30, 2022 13:08
@epilys epilys linked an issue Jun 30, 2022 that may be closed by this pull request
Update all tests to use the new Context API #2908
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@epilys epilys Awaiting requested review from epilys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update all tests to use the new Context API
3 participants
@ptitSeb @syrusakbary @epilys