Remove libxcb and libwayland dependencies from wasmer-cli release build #2963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #2822 For some reason these libraries get linked into the final release binary, which should not be the default (since these dependencies are only needed for the experimental-io extension).
fschutt
force-pushed
the
remove-deps
branch
5 times, most recently
from
1c1ec4a to
80c9d1c
Compare
The compilation of the actual code linking libxcbcommon-0 is now gated behind --feature="link_external_libs", while the crate continues to compile without the feature
|
bors r+ |
epilys
approved these changes
Jun 21, 2022
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #2920, since the framebuffer dependency is removed from the CI. The FB dependency was used in the
experimental-iofeature, which - for some reason - linkedlibxcbcommoninto the final binary on Linux.Review