Fix regression on gen_import_call_trampoline_arm64() #2948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitSeb
approved these changes
Jun 13, 2022
Fix clippy lints #2942 changed the `gen_import_call_trampoline_arm64()` code because clippy emitted a lint about the loop logic. However, the fix was wrong and was causing incorrect binary generation on arm64. More specifically, this was caught by test `serialize::test_deserialize::singlepass::*` on macos M1 (arm64)
epilys
force-pushed
the
fix-clippy-arm64-singlepass
branch
from
15ff6b9 to
485dde5
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix clippy lints #2942 changed the
gen_import_call_trampoline_arm64()code because clippy emitted a lint about the loop logic. However, the fix was wrong and was causing incorrect binary generation on arm64.More precisely, this was caught by test
serialize::test_deserialize::singlepass::*on macos M1 (arm64)This regression was not caught because tests are not run on ARM64 on Github Actions CI runners.