Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing dylib and staticlib engines in favor of a single Universal Engine #2946

Merged
merged 16 commits into from
Jun 16, 2022
Merged

Removing dylib and staticlib engines in favor of a single Universal Engine #2946

merged 16 commits into from
Jun 16, 2022

Conversation

epilys
Copy link
Contributor

@epilys epilys commented Jun 10, 2022 •
edited
Loading

Closes Refactor Engines into a single Universal Engine #2925

Review

  • Add a short description of the change to the CHANGELOG.md file

@epilys epilys added this to the v3.0 milestone Jun 10, 2022
@epilys epilys requested a review from syrusakbary as a code owner June 10, 2022 12:06
@epilys epilys linked an issue Jun 13, 2022 that may be closed by this pull request
Refactor Engines into a single Universal Engine #2925
Closed
@epilys epilys force-pushed the wasmer3-engines-refactor branch 3 times, most recently from e56c714 to f768704 Compare June 14, 2022 08:17
@epilys epilys requested a review from ptitSeb June 14, 2022 08:18
@epilys epilys changed the title Refactor Engines into a single Universal Engine Removing dylib and staticlib engines in favor of a single Universal Engine Jun 15, 2022
@epilys epilys force-pushed the wasmer3-engines-refactor branch 4 times, most recently from 0ec7e71 to 565f50d Compare June 16, 2022 10:05
epilys added 13 commits June 16, 2022 16:57
@epilys
Update CHANGELOG.md and migration_to_3.0.0.md
2f1c61e
@epilys
Make rkyv dependency required
065734b
@epilys
lib/types: remove ArchivableIndexMap struct
4a80830 
rkyv supports IndexMap via a feature flag, so having our own IndexMap
type is unnecessary.
@epilys
Update rkyv dependency to 0.7.38
699bd3f
@epilys
Remove engine-dylib
e9d54e1
@epilys
Remove engine-staticlib
8be0089
@epilys
Move wasmer_compiler errors to wasmer_types error module
feee4e3
@epilys
Move wasmer_artifact errors to wasmer_types error module
25057c8
@epilys
Move wasmer_compiler/{section,relocation}.rs to wasmer_types
b1f1939
@epilys
Move wasmer_compiler/{address_map, function, module, sourceloc, trap,…
8f539d1 
… unwind}.rs to wasmer_types
@epilys
Remove wasmer-{artifact,engine} and merge it into wasmer-compiler and…
a6173f9 
… wasmer-vm
@epilys
tests/integration/cli: add TARGET path detection to wasmer path
9ebe1c2
@epilys
Remove wasmer_engine_universal{,_artifact} and merge into wasmer_comp…
086205b 
…iler
epilys added 3 commits June 16, 2022 16:57
@epilys
wasmer-cli: remove configuration options for engines
7bf5d9d 
Since there's now only one engine, no need to expose it to the user.
@epilys
tests/compilers: remove Engine configuration
c9baa6e 
Since there's only one Engine now.
@epilys
Store: replace new() with new_with_engine() and make new() take Compi…
f744bac 
…lerConfig

Since there's one engine now, it doesn't make sense to initialize a
`Store` with the engine specifically. It's an extra redundant step for
the API user.
@epilys epilys force-pushed the wasmer3-engines-refactor branch from 565f50d to f744bac Compare June 16, 2022 13:57
@epilys
Copy link
Contributor Author

epilys commented Jun 16, 2022

bors r+ p=10

@bors
Copy link
Contributor

bors bot commented Jun 16, 2022

Build succeeded:

@bors bors bot merged commit 02b6989 into master Jun 16, 2022
@bors bors bot deleted the wasmer3-engines-refactor branch June 16, 2022 14:08
@GeorgKreuzmayr
Copy link

Hey @epilys,
thanks for the great work on wasmer!
I was recently using the "wasmer create-exe" command a lot and after this PR I am not sure about how to compile .wasm files to native code anymore. Could you give me a hint on that?

@epilys
Copy link
Contributor Author

epilys commented Jul 1, 2022

Hey @epilys, thanks for the great work on wasmer! I was recently using the "wasmer create-exe" command a lot and after this PR I am not sure about how to compile .wasm files to native code anymore. Could you give me a hint on that?

Hey @GeorgKreuzmayr, thanks for your kind words :). You will have to use the latest stable release 2.3 for now. Right now the current master branch tracks the development of the next major release, 3.0, and create-exe has been removed temporarily because it's going to be rewritten. master is not stable or even fully operational.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees

@ptitSeb ptitSeb

@epilys epilys

Labels
None yet
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.

Refactor Engines into a single Universal Engine
3 participants
@epilys @GeorgKreuzmayr @ptitSeb