Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ImportObject with new type Imports #2846

Merged
merged 3 commits into from
Apr 28, 2022
Merged

Replace ImportObject with new type Imports #2846

merged 3 commits into from
Apr 28, 2022

Conversation

epilys
Copy link
Contributor

@epilys epilys commented Apr 14, 2022 •
edited
Loading

TODO:

  • Update all references to ImportObject in documentation
  • Update migration document with interface changes

@epilys epilys requested a review from Amanieu April 14, 2022 16:33
@epilys epilys self-assigned this Apr 14, 2022
@epilys epilys requested a review from syrusakbary as a code owner April 14, 2022 16:33
@epilys epilys marked this pull request as draft April 14, 2022 16:34
epilys
epilys commented Apr 14, 2022
View reviewed changes
@epilys epilys force-pushed the wasmer3-importobject-to-imports branch 3 times, most recently from a9f610d to a2b2706 Compare April 15, 2022 14:26
@syrusakbary
Copy link
Member

Can we create a document named: Migration to 3.0 (similar to https://github.com/wasmerio/wasmer/blob/master/docs/migration_to_1.0.0.md) where we start describing the breaking changes and how people can upgrade to 3.0?

It will also make reviews on the API breaking changes for each PR a bit simpler :)

@epilys epilys force-pushed the wasmer3-importobject-to-imports branch 11 times, most recently from 0a6978a to e25740c Compare April 19, 2022 15:09
@epilys epilys linked an issue Apr 19, 2022 that may be closed by this pull request
Replace ImportObject, Resolver traits with less complex interface #2852
Closed
@epilys epilys force-pushed the wasmer3-importobject-to-imports branch 2 times, most recently from 399842f to bfc5219 Compare April 19, 2022 20:27
Amanieu
Amanieu reviewed Apr 19, 2022
View reviewed changes
@epilys epilys force-pushed the wasmer3-importobject-to-imports branch 4 times, most recently from f8d075f to 01c1aaa Compare April 26, 2022 09:48
@epilys epilys changed the title Replace ImportObject with new type Imports WIP Replace ImportObject with new type Imports Apr 26, 2022
@epilys epilys marked this pull request as ready for review April 26, 2022 09:52
@epilys epilys requested a review from syrusakbary April 26, 2022 11:40
@epilys epilys force-pushed the wasmer3-importobject-to-imports branch from 01c1aaa to c193800 Compare April 27, 2022 12:57
@syrusakbary syrusakbary mentioned this pull request Apr 27, 2022
Closed
@epilys epilys mentioned this pull request Apr 27, 2022
Closed
3 tasks
@epilys epilys requested a review from Amanieu April 27, 2022 18:00
Amanieu
Amanieu reviewed Apr 28, 2022
View reviewed changes
@epilys epilys force-pushed the wasmer3-importobject-to-imports branch from c193800 to 8b931bb Compare April 28, 2022 12:17
Amanieu
Amanieu reviewed Apr 28, 2022
View reviewed changes
@epilys epilys force-pushed the wasmer3-importobject-to-imports branch 2 times, most recently from 46b2b46 to 261c211 Compare April 28, 2022 14:51
@epilys epilys force-pushed the wasmer3-importobject-to-imports branch from 261c211 to 9bde9d8 Compare April 28, 2022 15:23
@epilys epilys merged commit fd32ade into wasmer3 Apr 28, 2022
@bors bors bot deleted the wasmer3-importobject-to-imports branch April 28, 2022 19:27
@epilys epilys mentioned this pull request Apr 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary left review comments

@Amanieu Amanieu Amanieu approved these changes

Assignees

@epilys epilys

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ImportObject, Resolver traits with less complex interface
3 participants
@epilys @syrusakbary @Amanieu