Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sock_accept on Unix #2842

Closed
wants to merge 1 commit into from
Closed

Implement sock_accept on Unix #2842

wants to merge 1 commit into from

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Apr 10, 2022

Description

This change implements sock_accept on Unix.

Review

  • Add a short description of the change to the CHANGELOG.md file

@fschutt fschutt marked this pull request as draft April 10, 2022 19:22
@fschutt fschutt force-pushed the implement-sock-accept branch from 10f9ba8 to 07c63ed Compare April 11, 2022 07:12
@fschutt fschutt force-pushed the implement-sock-accept branch from 07c63ed to 3b18ef0 Compare April 20, 2022 16:24
@fschutt
Copy link
Contributor Author

fschutt commented Apr 20, 2022

I seem to have missed a single #[cfg(unix)]. Fixed.

@heyjdp
Copy link

heyjdp commented May 24, 2022

Thanks for the PR, closing as needs more full implementation

@heyjdp heyjdp closed this May 24, 2022
@onokatio onokatio mentioned this pull request Sep 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fschutt @heyjdp