Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JsImportObject resolver #2828

Merged
merged 1 commit into from
Mar 27, 2022
Merged

Fix JsImportObject resolver #2828

merged 1 commit into from
Mar 27, 2022
+4 −1

Conversation

kateinoigakukun
Copy link
Contributor

Description

The JsImportObject.get_export implementation is apparently broken. The second argument of WASI.instantiate of @wasmer/wasi doesn't work at all due to this issue.

Review

  • Add a short description of the change to the CHANGELOG.md file

@kateinoigakukun kateinoigakukun force-pushed the katei/fix-js-import-object branch from 97e6995 to e09cf07 Compare March 27, 2022 16:34
syrusakbary
syrusakbary approved these changes Mar 27, 2022
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@syrusakbary
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 27, 2022

Build succeeded:

@bors bors bot merged commit 8b47e10 into wasmerio:master Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kateinoigakukun @syrusakbary