Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add versioning to cache #278

Merged
merged 9 commits into from
Mar 19, 2019
Merged

Add versioning to cache #278

merged 9 commits into from
Mar 19, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

resolves #272

@MarkMcCaskey MarkMcCaskey marked this pull request as ready for review March 19, 2019 00:53
@MarkMcCaskey
Copy link
Contributor Author

There are some issues that I noticed while doing this, the help text on wasmer cache --help seems to be missing (it's a default value which doesn't make much sense) and running wasmer cache clean before running anything with wasmer will cause a panic. These should both be easy to fix

@Hywan Hywan added 🎉 enhancement New feature! 📦 lib-deprecated About the deprecated crates 📦 lib-runtime labels Mar 19, 2019
lachlansneff
lachlansneff approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@lachlansneff lachlansneff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@lachlansneff
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Mar 19, 2019
@bors @lachlansneff
Merge #278
4a74382 
278: Add versioning to cache r=lachlansneff a=MarkMcCaskey

resolves #272 

Co-authored-by: Mark <[email protected]>
Co-authored-by: Mark McCaskey <[email protected]>
Co-authored-by: Lachlan Sneff <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 19, 2019

Build succeeded

@bors bors bot merged commit 5657be1 into master Mar 19, 2019
@bors bors bot deleted the add-versioning-to-cache branch March 19, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlansneff lachlansneff lachlansneff approved these changes

Assignees
No one assigned
Labels
🎉 enhancement New feature! 📦 lib-deprecated About the deprecated crates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache files should be version-dependent
3 participants
@MarkMcCaskey @lachlansneff @Hywan