Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-pass native code generation for x86-64 using dynasm. #276

Merged
merged 112 commits into from
Mar 21, 2019
Merged

Single-pass native code generation for x86-64 using dynasm. #276

merged 112 commits into from
Mar 21, 2019

Conversation

losfair
Copy link
Contributor

@losfair losfair commented Mar 17, 2019

No description provided.

losfair added 30 commits February 8, 2019 23:56
@losfair
Initial work on WebAssembly parser for Dynasm backend.
9649219
@losfair
Merge remote-tracking branch 'private/master' into feature/dynasm-bac…
f735471 
…kend
@losfair
Update dependencies.
af19f5c
@losfair
Code generation framework.
bbb27be
@losfair
Cleanup & add imports.
ffc1bde
@losfair
Codegen backend for x64.
2fbb5e3
@losfair
Calling conventions, value stack, and runtime stack layout.
4ebb22f
@losfair
stack: Helper functions and unified return types
a69c5b4
@losfair
Use System V calling convention and implement a few opcodes.
43df3dd
@losfair
codegen: More opcodes
7df7204
@losfair
Starting integration.
8d8db4a
@losfair
Emit a Return opcode if the last one is not return.
1526d35
@losfair
Now we can run add!
bb52a4e
@losfair
Mitigate a bug that causes incorrect code generation.
5583e96 
Still need to figure out why R8 and higher registers don't work.
@losfair
Operators.
93d2713
@losfair
Control frames, jumps & stack unwinding.
61c8350
@losfair
Operator::Br and control stack fixes
aaabbf1
@losfair
Remove a hack in parser.
6f97ebd
@losfair
Handle unreachable and fix return.
63b3f41
@losfair
Block and conditional branch.
7c43993
@losfair
Unary operators, comparison opcodes, loops, etc.
08a2ec8
@losfair
Single-pass backend tests.
693c9fd
@losfair
Update dependencies
e9c0325
@losfair
Changed to using custom calling conventions; Implemented direct calls.
09cbd4a
@losfair
Add direct call test
b2f5f77
@losfair
Code generation for br_table.
dbebdf9
@losfair
Fix function calls.
2432a6c
@losfair
Add test for br_table.
da1a3fa
@losfair
Implement native call & fix stack alignment.
80812e3
@losfair
Fix argument passing at entry.
78fd995
@bjfish
Copy link
Contributor

bjfish commented Mar 19, 2019 •
edited
Loading

@losfair I think there is a command to install on nightly , maybe rustup component add clippy —toolchain=nightly
Found in this page: https://github.com/rust-lang/rust-clippy/blob/master/README.md

@losfair losfair force-pushed the feature/dynasm-backend branch from 98ccc4f to 295efbf Compare March 19, 2019 17:52
@losfair
Copy link
Contributor Author

losfair commented Mar 19, 2019

bors try

bors bot added a commit that referenced this pull request Mar 19, 2019
@bors
Try #276:
fa33bb9
@bors
Copy link
Contributor

bors bot commented Mar 19, 2019

try

Build succeeded

bjfish
bjfish reviewed Mar 20, 2019
View reviewed changes
Cargo.toml Show resolved Hide resolved
bjfish
bjfish reviewed Mar 20, 2019
View reviewed changes
Cargo.toml Show resolved Hide resolved
@losfair losfair requested review from bjfish and lachlansneff March 20, 2019 15:15
lachlansneff
lachlansneff suggested changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@lachlansneff lachlansneff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost!

lib/runtime-core/src/vm.rs Outdated Show resolved Hide resolved
lib/runtime-core/src/vm.rs Show resolved Hide resolved
lachlansneff
lachlansneff suggested changes Mar 21, 2019
View reviewed changes
lib/dynasm-backend/src/codegen_x64.rs
(**(*_vmctx).internal.memories).base,
(**(*_vmctx).internal.memories).bound,
)
let vmctx = _vmctx as *mut vm::InternalCtx;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make the ctx parameter of this function &mut vm::InternalCtx.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the definition of the ProtectedCaller trait needs to be changed. I doubt whether this is really needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my mistake. I thought this was part of a different function. Why does the protected caller need to figure out where the memory is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because CALL_WASM needs to setup a register containing memory information (base, bound) which is passed in as a paremeter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. Let's merge this and then discuss implementation later.

@lachlansneff
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Mar 21, 2019
@bors @losfair
Merge #276
fca2fa1 
276: Single-pass native code generation for x86-64 using dynasm. r=lachlansneff a=losfair



Co-authored-by: losfair <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 21, 2019

Build failed

@losfair losfair force-pushed the feature/dynasm-backend branch from f2d7223 to 08ba696 Compare March 21, 2019 01:24
@losfair
Copy link
Contributor Author

losfair commented Mar 21, 2019

bors r+

bors bot added a commit that referenced this pull request Mar 21, 2019
@bors @losfair
Merge #276
758ccc6 
276: Single-pass native code generation for x86-64 using dynasm. r=losfair a=losfair



Co-authored-by: losfair <[email protected]>
@bors
Copy link
Contributor

bors bot commented Mar 21, 2019

Build succeeded

@bors bors bot merged commit 08ba696 into master Mar 21, 2019
@bors bors bot deleted the feature/dynasm-backend branch March 21, 2019 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlansneff lachlansneff lachlansneff approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

@xmclark xmclark Awaiting requested review from xmclark

@bjfish bjfish Awaiting requested review from bjfish

Assignees
No one assigned
Labels
🎉 enhancement New feature! 📦 lib-deprecated About the deprecated crates 📦 lib-emscripten About wasmer-emscripten 🧪 tests I love tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@losfair @bjfish @lachlansneff @syrusakbary @xmclark @Hywan