Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exact version for Wasmer crate dependencies #2759

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Use exact version for Wasmer crate dependencies #2759

merged 2 commits into from
Jan 20, 2022

Conversation

Amanieu
Copy link
Contributor

@Amanieu Amanieu commented Jan 19, 2022

We don't guarantee API compatibility between internal Wasmer crates when making minor version bumps. This will avoid issues like #2749 in the future.

@Amanieu
Use exact version for Wasmer crate dependencies
fb7a572 
We don't guarantee API compatibility between internal Wasmer crates when
making minor version bumps.
@Amanieu Amanieu requested a review from ptitSeb January 19, 2022 21:37
@Amanieu Amanieu requested a review from syrusakbary as a code owner January 19, 2022 21:37
@ptitSeb
Copy link
Contributor

ptitSeb commented Jan 20, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Jan 20, 2022

Build succeeded:

@bors bors bot merged commit 3501e48 into master Jan 20, 2022
@bors bors bot deleted the exact-version branch January 20, 2022 10:03
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Amanieu @ptitSeb @syrusakbary