Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added externs_vec method to the ImportObject #2726

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Added externs_vec method to the ImportObject #2726

merged 2 commits into from
Dec 17, 2021

Conversation

syrusakbary
Copy link
Member

Description

This PR is needed to be able to consume the ImportObject in a more sane way than using Exports using Extern instead (since Export is Engine related, and Extern is API related).

@syrusakbary syrusakbary requested a review from Amanieu December 15, 2021 12:01
@syrusakbary syrusakbary mentioned this pull request Dec 15, 2021
Merged
@Amanieu
Copy link
Contributor

Amanieu commented Dec 17, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 17, 2021

Build succeeded:

@bors bors bot merged commit c9eab66 into master Dec 17, 2021
@bors bors bot deleted the improved-imports branch December 17, 2021 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syrusakbary @Amanieu