Added access to the raw Wasm instance #2724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanieu
reviewed
Dec 14, 2021
| @@ -173,6 +173,12 @@ impl Instance { | |||
| pub fn store(&self) -> &Store { | |||
| self.module.store() | |||
| } | |||
|
|
|||
| /// Returns the inner WebAssembly Instance | |||
| #[doc(hidden)] | |||
There was a problem hiding this comment.
Is this API meant to be publicly usable? In that case it shouldn't be hidden from the documentation.
There was a problem hiding this comment.
Because it differs from the SYS API, I rather keep it hidden so people don't rely on it.
Although, we need it for wasmer-js
Amanieu
approved these changes
Dec 14, 2021
|
Merging directly to fasten the process (no existing code has been changed) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to solve this issue in wasmer-js we need to expose access to the underlying WebAssembly instance:
wasmerio/wasmer-js#284