Make module serialization deterministic #2692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to test #2173, the empty test always pass while the table one fails sometimes.
syrusakbary
reviewed
Nov 22, 2021
fuzz/fuzz_targets/deterministic.rs
Outdated
Comment on lines
60
to
76
| // let mut compiler = LLVM::default(); | ||
| // compiler.canonicalize_nans(true); | ||
| // compiler.enable_verifier(); | ||
| // compile_and_compare("jit-llvm", JIT::new(compiler.clone()).engine(), &wasm_bytes); | ||
| // compile_and_compare("native-llvm", Native::new(compiler).engine(), &wasm_bytes); | ||
|
|
||
| // let compiler = Singlepass::default(); | ||
| // compile_and_compare( | ||
| // "jit-singlepass", | ||
| // JIT::new(compiler.clone()).engine(), | ||
| // &wasm_bytes, | ||
| // ); | ||
| // compile_and_compare( | ||
| // "native-singlepass", | ||
| // Native::new(compiler).engine(), | ||
| // &wasm_bytes, | ||
| // ); |
There was a problem hiding this comment.
Can we re-enable this ones?
syrusakbary
approved these changes
Nov 22, 2021
|
It seems tests failed because of not enough memory in the VM. We can try to merge bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 22, 2021
2692: Make module serialization deterministic r=syrusakbary a=Amanieu Fixes #2173 Includes the tests from #2184. Co-authored-by: Amanieu d'Antras <[email protected]> Co-authored-by: Anbang Wen <[email protected]>
|
Canceled. |
|
bors r+ |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2173
Includes the tests from #2184.