Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 32-bit memories with 65536 pages #2677

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Support 32-bit memories with 65536 pages #2677

merged 2 commits into from
Nov 10, 2021
+39 −25

Conversation

Amanieu
Copy link
Contributor

@Amanieu Amanieu commented Nov 10, 2021

Fixes #2187

@Amanieu Amanieu requested a review from syrusakbary as a code owner November 10, 2021 14:56
@ptitSeb ptitSeb self-requested a review November 10, 2021 15:07
@ptitSeb
Copy link
Contributor

ptitSeb commented Nov 10, 2021

Windows test not passing because the Swapfile on the test system is not big enough. Should the test be disabled on Windows or can the CI modified?

@Amanieu
Copy link
Contributor Author

Amanieu commented Nov 10, 2021

Let's just disable it on Windows.

@ptitSeb
Copy link
Contributor

ptitSeb commented Nov 10, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 10, 2021

Build succeeded:

@bors bors bot merged commit 2b104a8 into master Nov 10, 2021
@bors bors bot deleted the 65536_pages branch November 10, 2021 16:59
@Amanieu Amanieu mentioned this pull request Nov 10, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees

@ptitSeb ptitSeb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can't represent 65536 pages
3 participants
@Amanieu @ptitSeb @syrusakbary