Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(windows) Fix slow memory grow handling (fix #2260) #2666

Merged
merged 5 commits into from
Nov 8, 2021
Merged

fix(windows) Fix slow memory grow handling (fix #2260) #2666

merged 5 commits into from
Nov 8, 2021

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Nov 8, 2021

Description

Fix slowiness on Windows plateforms with "memory grow".

Will fix #2260 and should speedup Windows use in general.

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner November 8, 2021 14:44
@ptitSeb ptitSeb requested review from Amanieu and removed request for syrusakbary November 8, 2021 14:44
@Amanieu
Copy link
Contributor

Amanieu commented Nov 8, 2021

bors r+

bors bot added a commit that referenced this pull request Nov 8, 2021
@bors @ptitSeb
Merge #2666
0569267 
2666: fix(windows) Fix slow memory grow handling (fix #2260) r=Amanieu a=ptitSeb

# Description
Fix slowiness on Windows plateforms with "memory grow".

Will fix #2260 and should speedup Windows use in general.

Co-authored-by: ptitSeb <[email protected]>
@bors
Copy link
Contributor

bors bot commented Nov 8, 2021

Build failed:

@ptitSeb
Copy link
Contributor Author

ptitSeb commented Nov 8, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 8, 2021

Build succeeded:

@bors bors bot merged commit e275bd4 into master Nov 8, 2021
@bors bors bot deleted the fix_windows_memory_slowgrow branch November 8, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scenario with very slow function execution in Wasmer on Windows compared to other runtimes and a native app
2 participants
@ptitSeb @Amanieu