Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify deps #2662

Closed
wants to merge 4 commits into from
Closed

Simplify deps #2662

wants to merge 4 commits into from

Conversation

syrusakbary
Copy link
Member

Description

This PR simplifies the dependencies of Wasmer to make possible using compilers (just to compile, not run) with Wasmer-js. This PR achieves:

  • Remove wasmer_vm dependency on all compiler crates
  • Remove rkyv dependency on wasmer_vm
  • Move TrapCode, VMOffsets, MemoryStyle and MemoryTable to wasmer_types

@syrusakbary syrusakbary requested a review from Amanieu November 5, 2021 14:17
@Amanieu
Copy link
Contributor

Amanieu commented Nov 10, 2021

error[E0433]: failed to resolve: use of undeclared crate or module `wasmer_vm`
  --> lib/compiler-llvm/src/abi/aarch64_systemv.rs:74:46
   |
74 |                         std::mem::align_of::<wasmer_vm::VMContext>()
   |                                              ^^^^^^^^^ use of undeclared crate or module `wasmer_vm`

error[E0433]: failed to resolve: use of undeclared crate or module `wasmer_vm`
  --> lib/compiler-llvm/src/abi/x86_64_systemv.rs:78:46
   |
78 |                         std::mem::align_of::<wasmer_vm::VMContext>()
   |                                              ^^^^^^^^^ use of undeclared crate or module `wasmer_vm`

@syrusakbary
Copy link
Member Author

Closing this PR in favor of #2851

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants