Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument parsing of --dir and --mapdir #2655

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Fix argument parsing of --dir and --mapdir #2655

merged 1 commit into from
Nov 5, 2021

Conversation

Amanieu
Copy link
Contributor

@Amanieu Amanieu commented Nov 5, 2021

Previously in "wasmer --dir foo bar.wasm" the "bar.wasm" was being
treated as another directory instead of the module to run.

Fixes #2445

Review

  • Add a short description of the change to the CHANGELOG.md file

Previously in "wasmer --dir foo bar.wasm" the "bar.wasm" was being
treated as another directory instead of the module to run.

Fixes #2445
@Amanieu Amanieu requested a review from syrusakbary as a code owner November 5, 2021 00:18
@syrusakbary
Copy link
Member

bors r+

@ptitSeb ptitSeb assigned Amanieu and unassigned Amanieu Nov 5, 2021
@bors
Copy link
Contributor

bors bot commented Nov 5, 2021

@bors bors bot merged commit c513b39 into master Nov 5, 2021
@bors bors bot deleted the arg_parsing branch November 5, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI args in run subcommand: wasm module can't follow --dir or --mapdir with no =
2 participants