Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cross-compilation with singlepass compiler #2635

Merged
merged 1 commit into from
Oct 25, 2021
Merged

fix cross-compilation with singlepass compiler #2635

merged 1 commit into from
Oct 25, 2021

Conversation

matklad
Copy link
Contributor

@matklad matklad commented Oct 25, 2021

Description

Fix cross-compilation with singlepass compiler

Review

  • Add a short description of the change to the CHANGELOG.md file

@matklad matklad requested a review from syrusakbary as a code owner October 25, 2021 12:29
@matklad matklad force-pushed the singlepass-cross-compilation-fix branch from d66177e to 2fe1b58 Compare October 25, 2021 12:29
@matklad
Copy link
Contributor Author

matklad commented Oct 25, 2021

Note: it probably is best to fix this on dynasm's side, but, as far as I know, there isn't a simple trick to do that: https://stackoverflow.com/questions/58176547/can-proc-macros-determine-the-target-of-the-invoking-compilation

syrusakbary
syrusakbary approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syrusakbary
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 25, 2021

Build succeeded:

@bors bors bot merged commit e389ad0 into wasmerio:master Oct 25, 2021
@matklad matklad mentioned this pull request Oct 25, 2021
Merged
Amanieu pushed a commit that referenced this pull request Nov 4, 2021
@bors @matklad @Amanieu
Merge #2635
5dde7f7 
2635: fix cross-compilation with singlepass compiler r=syrusakbary a=matklad

<!--
Prior to submitting a PR, review the CONTRIBUTING.md document for recommendations on how to test:
https://github.com/wasmerio/wasmer/blob/master/CONTRIBUTING.md#pull-requests

-->

# Description

Fix cross-compilation with singlepass compiler

# Review

- [ ] Add a short description of the change to the CHANGELOG.md file

Co-authored-by: Aleksey Kladov <[email protected]>
@syrusakbary syrusakbary added this to the v2.1 milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
project-near
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@matklad @syrusakbary