Feat llvm aarch64 relocs #2599
Merged
Feat llvm aarch64 relocs #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-universal on linux-aarch64 are OK now)
…t least coremark works now)
|
bors try |
tryBuild failed: |
syrusakbary
reviewed
Oct 11, 2021
syrusakbary
reviewed
Oct 11, 2021
syrusakbary
reviewed
Oct 11, 2021
|
bors try |
syrusakbary
reviewed
Oct 12, 2021
syrusakbary
reviewed
Oct 12, 2021
|
bors try |
syrusakbary
reviewed
Oct 12, 2021
There was a problem hiding this comment.
The PR looks good to me. Waiting on feedback from @Amanieu to approve or request further changes
Amanieu
reviewed
Oct 12, 2021
|
bors try |
tryAlready running a review |
Amanieu
suggested changes
Oct 18, 2021
| @@ -303,6 +304,37 @@ impl Compiler for LLVMCompiler { | |||
| }) | |||
| .collect::<PrimaryMap<LocalFunctionIndex, _>>(); | |||
|
|
|||
| let trampolines = match target.triple().architecture { | |||
| Architecture::Aarch64(_) => { | |||
| let nj = 16; | |||
There was a problem hiding this comment.
Use onejump.len() instead of hard-coding.
There was a problem hiding this comment.
Why is the number of slots hard-coded to 16?
There was a problem hiding this comment.
Because I need to hardcode some value. Cant resize the section later.
Amanieu
approved these changes
Oct 19, 2021
|
bors r+ |
This was referenced Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved Aarch64 support with LLVM by adding some missing relocations.
Linux/Aarch64 works fine with that, including with Universal engine.
macOS/Aarch64 still have issues with Universal engine.