Add ImportObject::get_namespace_exports #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amanieu
force-pushed
the
get_namespace_exports
branch
2 times, most recently
from
068fc1f to
93511a2
Compare
This allows the contents of an existing namespace to be added to by extracting an `Exports` from it, adding to that `Exports` and then replacing the existing namespace with the modified `Exports`.
Amanieu
force-pushed
the
get_namespace_exports
branch
from
93511a2 to
35d6c02
Compare
syrusakbary
reviewed
Oct 1, 2021
Comment on lines
+23
to
+25
| fn as_exports(&self) -> Option<Exports> { | ||
| None | ||
| } |
There was a problem hiding this comment.
Why Option? Also, why a default impl?
There was a problem hiding this comment.
For backward compatibility with any existing implementations of LikeNamespace outside wasmer.
There was a problem hiding this comment.
If backwards compatibility was not a concern then I would remove LikeNamespace entirely and use Exports directly in ImportObject.
syrusakbary
approved these changes
Oct 1, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 4, 2021
2592: Add ImportObject::get_namespace_exports r=syrusakbary a=Amanieu This allows the contents of an existing namespace to be added to by extracting an `Exports` from it, adding to that `Exports` and then replacing the existing namespace with the modified `Exports`. Co-authored-by: Amanieu d'Antras <[email protected]>
|
Build failed: |
|
Oh, still fd_rename_path on windows x64 that fails? |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 4, 2021
2592: Add ImportObject::get_namespace_exports r=syrusakbary a=Amanieu This allows the contents of an existing namespace to be added to by extracting an `Exports` from it, adding to that `Exports` and then replacing the existing namespace with the modified `Exports`. Co-authored-by: Amanieu d'Antras <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
|
Let's try again bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 11, 2021
2592: Add ImportObject::get_namespace_exports r=syrusakbary a=Amanieu This allows the contents of an existing namespace to be added to by extracting an `Exports` from it, adding to that `Exports` and then replacing the existing namespace with the modified `Exports`. Co-authored-by: Amanieu d'Antras <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 12, 2021
2592: Add ImportObject::get_namespace_exports r=syrusakbary a=Amanieu This allows the contents of an existing namespace to be added to by extracting an `Exports` from it, adding to that `Exports` and then replacing the existing namespace with the modified `Exports`. Co-authored-by: Amanieu d'Antras <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
|
Build failed: |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the contents of an existing namespace to be added to by
extracting an
Exportsfrom it, adding to thatExportsand thenreplacing the existing namespace with the modified
Exports.