-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/singlepass windows #2574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now we are using compilation flags #[cfg(target_os = "windows")]
to determine the output.
To allow cross-compilation it would be great to have it depending on a runtime flag (we can add the compiler::Target
to the Singlepass
struct, and check the target OS there)
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
bors try |
tryBuild failed: |
…nvestigation, skip the test for now
… uncoditionnaly for now
…mp on Windows to avoid potential issue with jitted code
bors try |
tryBuild failed: |
bors try |
Great stuff, thank you! This is big news. CHANGELOG entry seems missing. Would love to see this released. Happy to test. |
Description
Added Windows x86_64 support to SinglePass Compiler.
Compared to System V ABI, the Windows ABI changed the way argument are send to function in the following way: