feat(runtime) Get ready for tiering #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lachlansneff
added
🎉 enhancement
lachlansneff
changed the title
xmclark
approved these changes
Mar 8, 2019
| } | ||
| } | ||
|
|
||
| fn generate_local_functions(module: &ModuleInner) -> BoxedMap<LocalFuncIndex, *const vm::Func> { | ||
| (0..module.info.func_assoc.len() - module.info.imported_functions.len()) |
There was a problem hiding this comment.
is this constructing a range? do we have confidence this will always result in a positive set of numbers?
There was a problem hiding this comment.
Yeah, I do. The total number of functions will always be greater than or equal to the number of imported functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds various fixes and runtime changes in order to be ready to support compiler tiering.