Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement wasi dir path rename #2559

Merged
merged 9 commits into from
Sep 9, 2021
Merged

Implement wasi dir path rename #2559

merged 9 commits into from
Sep 9, 2021

Conversation

bnjjj
Copy link
Contributor

@bnjjj bnjjj commented Sep 7, 2021

Description

Related to #2557

I also add command to wasi-test-generator to generate only for specific tests and not always for all tests.

@bnjjj bnjjj requested a review from Hywan as a code owner September 7, 2021 11:59
Hywan
Hywan reviewed Sep 7, 2021
View reviewed changes
Makefile Outdated Show resolved Hide resolved
lib/c-api/wasmer.h Outdated Show resolved Hide resolved
tests/wasi-wast/src/wasitests.rs Outdated Show resolved Hide resolved
@Hywan Hywan added 📦 lib-wasi About wasmer-wasi 🧪 tests I love tests 🎉 enhancement New feature! labels Sep 7, 2021
@bnjjj bnjjj requested a review from Hywan September 7, 2021 16:07
@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Sep 8, 2021
@bors @syrusakbary @bnjjj
Merge #2559
579e09d 
2559: Implement wasi dir path rename r=syrusakbary a=bnjjj

# Description
Related to #2557 

I also add command to wasi-test-generator to generate only for specific tests and not always for all tests.


Co-authored-by: Syrus Akbary <[email protected]>
Co-authored-by: Benjamin Coenen <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 8, 2021

Build failed:

@bnjjj
Copy link
Contributor Author

bnjjj commented Sep 8, 2021

Any idea of what could be wrong here @syrusakbary ?

@syrusakbary
Copy link
Member

Tests were failing on wasmer master, now everything should be fine. I think triggering a merge again should solve it.

bors r+

bors bot added a commit that referenced this pull request Sep 9, 2021
@bors @syrusakbary @bnjjj
Merge #2559
4b23b63 
2559: Implement wasi dir path rename r=syrusakbary a=bnjjj

# Description
Related to #2557 

I also add command to wasi-test-generator to generate only for specific tests and not always for all tests.


Co-authored-by: Syrus Akbary <[email protected]>
Co-authored-by: Benjamin Coenen <[email protected]>
Co-authored-by: Coenen Benjamin <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 9, 2021

Canceled.

@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Sep 9, 2021
@bors @syrusakbary @bnjjj
Merge #2559
1c4ff1b 
2559: Implement wasi dir path rename r=syrusakbary a=bnjjj

# Description
Related to #2557 

I also add command to wasi-test-generator to generate only for specific tests and not always for all tests.


Co-authored-by: Syrus Akbary <[email protected]>
Co-authored-by: Benjamin Coenen <[email protected]>
Co-authored-by: Coenen Benjamin <[email protected]>
@bors
Copy link
Contributor

bors bot commented Sep 9, 2021

Build failed:

@syrusakbary
Copy link
Member

I think we hit a edge case @bnjjj

---- wasi::wasitests::snapshot1::host_fs::fd_rename_path::cranelift::universal stdout ----
Running wasi wast `tests/wasi-wast/wasi/snapshot1/fd_rename_path.wast`
Error: failed to run WASI `_start` function: failed with stdout: ""
stderr: "thread 'main' panicked at 'cannot create the directory: Os { code: 20, kind: AlreadyExists, message: "File exists" }', /tmp/.tmp4mb8cH/wasi_modified_version_fd_rename_path.rs:10:35

@bnjjj
Copy link
Contributor Author

bnjjj commented Sep 9, 2021

Ok will try to reproduce and add more tests ASAP

@bnjjj
clean the environment in tests
f449ae5 
Signed-off-by: Benjamin Coenen <[email protected]>
@syrusakbary
Copy link
Member

bors r-

@syrusakbary
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 9, 2021

Build succeeded:

@bors bors bot merged commit d7e7c0d into wasmerio:master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Awaiting requested review from Hywan

Assignees
No one assigned
Labels
🎉 enhancement New feature! 📦 lib-wasi About wasmer-wasi 🧪 tests I love tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnjjj @syrusakbary @Hywan