feat(vfs) Add ability to rename a file with mem_fs
#2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
This patch adds test cases for renaming a file or a directory, and for renaming + moving. That's different because this patch also implements a shortcut when a file or directory is simply renamed, we don't need to update the parent's children, only the modified time.
syrusakbary
approved these changes
Sep 3, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 3, 2021
2546: test(wasi) Running all WASI tests with `wasmer_vfs::mem_fs` too r=Hywan a=Hywan # Description This WIP PR updates our WASI test framework to specifically test with `wasmer_vfs::host_fs` (the default, as of now) _and_ with `wasmer_vfs::mem_fs` (🆕!). Bug trophies: * #2545 * #2550 * #2551 # Review - [ ] Add a short description of the change to the CHANGELOG.md file Co-authored-by: Ivan Enderlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch updates
wasmer_vfs::mem_fs::FileSystem::renameto handle file. Directories were handle previously, but not file.Tests must be added though.It solves the last bits of #2546.