Fix probestack #2548
Merged
Fix probestack #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d enabled skip_stack_gard_page tests
syrusakbary
reviewed
Sep 1, 2021
syrusakbary
reviewed
Sep 1, 2021
syrusakbary
approved these changes
Sep 1, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 1, 2021
2548: Fix probestack r=ptitSeb a=ptitSeb # Description The `skip_stack_gard_page` were failing. The patch first add a trampoline for the PROBEGUARD function on x86_64 build, as this one comes from some runtime and can be too far away from generated code for a regular 32bits relative address (this fix a segfault when a generated function needs a call to probeguard). The patch also add a special case for StackOverflow error, and doesn't check if the error comes from Wasm code (as the stack overflow will comes from a runtime library, generated by the probeguard function). Co-authored-by: Syrus Akbary <[email protected]> Co-authored-by: ptitSeb <[email protected]>
|
Build failed: |
… macOS and windows
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 1, 2021
2548: Fix probestack r=ptitSeb a=ptitSeb # Description The `skip_stack_gard_page` were failing. The patch first add a trampoline for the PROBEGUARD function on x86_64 build, as this one comes from some runtime and can be too far away from generated code for a regular 32bits relative address (this fix a segfault when a generated function needs a call to probeguard). The patch also add a special case for StackOverflow error, and doesn't check if the error comes from Wasm code (as the stack overflow will comes from a runtime library, generated by the probeguard function). Co-authored-by: Syrus Akbary <[email protected]> Co-authored-by: ptitSeb <[email protected]>
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 1, 2021
2548: Fix probestack r=ptitSeb a=ptitSeb # Description The `skip_stack_gard_page` were failing. The patch first add a trampoline for the PROBEGUARD function on x86_64 build, as this one comes from some runtime and can be too far away from generated code for a regular 32bits relative address (this fix a segfault when a generated function needs a call to probeguard). The patch also add a special case for StackOverflow error, and doesn't check if the error comes from Wasm code (as the stack overflow will comes from a runtime library, generated by the probeguard function). Co-authored-by: Syrus Akbary <[email protected]> Co-authored-by: ptitSeb <[email protected]>
|
Build failed: |
… of the probestack trampoline
…n linux-x86_64 to allow relocation of wasmer_vm_probestack symbol
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 2, 2021
2548: Fix probestack r=ptitSeb a=ptitSeb # Description The `skip_stack_gard_page` were failing. The patch first add a trampoline for the PROBEGUARD function on x86_64 build, as this one comes from some runtime and can be too far away from generated code for a regular 32bits relative address (this fix a segfault when a generated function needs a call to probeguard). The patch also add a special case for StackOverflow error, and doesn't check if the error comes from Wasm code (as the stack overflow will comes from a runtime library, generated by the probeguard function). Co-authored-by: Syrus Akbary <[email protected]> Co-authored-by: ptitSeb <[email protected]>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 2, 2021
2548: Fix probestack r=ptitSeb a=ptitSeb # Description The `skip_stack_gard_page` were failing. The patch first add a trampoline for the PROBEGUARD function on x86_64 build, as this one comes from some runtime and can be too far away from generated code for a regular 32bits relative address (this fix a segfault when a generated function needs a call to probeguard). The patch also add a special case for StackOverflow error, and doesn't check if the error comes from Wasm code (as the stack overflow will comes from a runtime library, generated by the probeguard function). Co-authored-by: Syrus Akbary <[email protected]> Co-authored-by: ptitSeb <[email protected]>
|
Build failed: |
|
Not sure if it's flaky, let's try again. bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 2, 2021
2548: Fix probestack r=syrusakbary a=ptitSeb # Description The `skip_stack_gard_page` were failing. The patch first add a trampoline for the PROBEGUARD function on x86_64 build, as this one comes from some runtime and can be too far away from generated code for a regular 32bits relative address (this fix a segfault when a generated function needs a call to probeguard). The patch also add a special case for StackOverflow error, and doesn't check if the error comes from Wasm code (as the stack overflow will comes from a runtime library, generated by the probeguard function). Co-authored-by: Syrus Akbary <[email protected]> Co-authored-by: ptitSeb <[email protected]>
|
Build failed: |
|
I reproduce on my side now. Working on a fix... |
…o use an empty vector instead
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
skip_stack_gard_pagewere failing.The patch first add a trampoline for the PROBEGUARD function on x86_64 build, as this one comes from some runtime and can be too far away from generated code for a regular 32bits relative address (this fix a segfault when a generated function needs a call to probeguard).
The patch also add a special case for StackOverflow error, and doesn't check if the error comes from Wasm code (as the stack overflow will comes from a runtime library, generated by the probeguard function).