fix(engine-dylib) Remove temporary file used to creating an artifact #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hywan
added
bug
Hywan
added a commit
to Hywan/wasmer
that referenced
this pull request
Aug 12, 2021
syrusakbary
approved these changes
Aug 13, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 13, 2021
2518: fix(engine-dylib) Remove temporary file used to creating an artifact r=syrusakbary a=Hywan # Description When creating an artifact, a first temporary file is created and kept to prevent the file from being removed by the system. This patch removes that temporary file manually whatever the linker fails or not. Fixes #2501. # Review - [x] Add a short description of the change to the CHANGELOG.md file Co-authored-by: Ivan Enderlin <[email protected]>
|
Build failed: |
When creating an artifact, a first temporary file is created and kept to prevent the file from being removed by the system. This patch removes that temporary file manually whatever the linker fails or not.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When creating an artifact, a first temporary file is created and kept
to prevent the file from being removed by the system. This patch
removes that temporary file manually whatever the linker fails or not.
Fixes #2501.
Review