Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for calling dynamic functions defined on the host #2511

Merged
merged 8 commits into from
Aug 11, 2021
Merged

Added support for calling dynamic functions defined on the host #2511

merged 8 commits into from
Aug 11, 2021

Conversation

syrusakbary
Copy link
Member

Description

Added support for calling dynamic functions defined on the host.

Review

  • Add a short description of the change to the CHANGELOG.md file

@syrusakbary
Copy link
Member Author

Note: this PR is also changing the locations of sys test files to the parent dir, as they were not currently being executed

@syrusakbary
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2021
@bors
Try #2511:
93c80cf
@syrusakbary syrusakbary requested a review from losfair as a code owner August 10, 2021 18:40
@bors
Copy link
Contributor

bors bot commented Aug 10, 2021

try

Build failed:

@syrusakbary
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2021
@bors
Try #2511:
3e11fcb
@bors
Copy link
Contributor

bors bot commented Aug 10, 2021

try

Build failed:

@syrusakbary
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2021
@bors
Try #2511:
60c12dc
@bors
Copy link
Contributor

bors bot commented Aug 10, 2021

try

Build failed:

@syrusakbary
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 10, 2021
@bors
Try #2511:
d617f6e
@bors
Copy link
Contributor

bors bot commented Aug 10, 2021

try

Timed out.

@syrusakbary
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Aug 11, 2021
@bors
Try #2511:
110639d
@bors
Copy link
Contributor

bors bot commented Aug 11, 2021

try

Build succeeded:

@syrusakbary
Copy link
Member Author

Merging manually as the current master is red, and this adds a small and tested feature (nothing controversial)

@syrusakbary syrusakbary merged commit 22634fa into master Aug 11, 2021
@bors bors bot deleted the feature/call-host-dynamic branch August 11, 2021 08:45
Hywan
Hywan reviewed Aug 12, 2021
View reviewed changes
tests/ignores.txt
@@ -35,6 +35,8 @@ cranelift multi_value_imports::dylib
singlepass multi_value_imports::dylib
singlepass multi_value_imports::dynamic

# Memory load doesn't trap as expected when out out bounds in Windows
windows+cranelift spec::memory_grow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a hard one :-/

@Hywan Hywan added 📦 lib-api About wasmer 📦 lib-compiler-cranelift About wasmer-compiler-cranelift 🎉 enhancement New feature! labels Aug 12, 2021
@Hywan Hywan added 📦 lib-compiler-llvm About wasmer-compiler-llvm 📦 lib-compiler-singlepass About wasmer-compiler-singlepass labels Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan left review comments

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

@losfair losfair Awaiting requested review from losfair

Assignees
No one assigned
Labels
🎉 enhancement New feature! 📦 lib-api About wasmer 📦 lib-compiler-cranelift About wasmer-compiler-cranelift 📦 lib-compiler-llvm About wasmer-compiler-llvm 📦 lib-compiler-singlepass About wasmer-compiler-singlepass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syrusakbary @Hywan