Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Singlepass function environment in indirect calls #2494

Merged
merged 3 commits into from
Jul 29, 2021
Merged

Fix Singlepass function environment in indirect calls #2494

merged 3 commits into from
Jul 29, 2021

Conversation

syrusakbary
Copy link
Member

This PR fixes the corruption of WasmerEnv when using Singlepass in indirect function calls #2329 .

Review

  • Add a short description of the change to the CHANGELOG.md file

@syrusakbary
Copy link
Member Author

We only do this to trigger the failure to verify that is fixed later.

bors try

bors bot added a commit that referenced this pull request Jul 28, 2021
@bors
Try #2494:
db4678b
@bors
Copy link
Contributor

bors bot commented Jul 28, 2021

try

Build succeeded:

@syrusakbary
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jul 29, 2021
@bors
Try #2494:
8c70103
@bors
Copy link
Contributor

bors bot commented Jul 29, 2021

try

Build failed:

@syrusakbary syrusakbary requested a review from losfair as a code owner July 29, 2021 00:10
@syrusakbary
Copy link
Member Author

Now, we will verify that the fix is indeed fixing the issue: 9ecedc3

bors try

bors bot added a commit that referenced this pull request Jul 29, 2021
@bors
Try #2494:
b6aefcf
@bors
Copy link
Contributor

bors bot commented Jul 29, 2021

try

Build succeeded:

@syrusakbary
Copy link
Member Author

Merging

@syrusakbary syrusakbary merged commit e567bb7 into master Jul 29, 2021
@bors bors bot deleted the fix-issue-2329 branch July 29, 2021 01:13
@syrusakbary syrusakbary mentioned this pull request Jul 29, 2021
Closed
@Hywan Hywan added bug Something isn't working 📦 lib-compiler-singlepass About wasmer-compiler-singlepass labels Aug 12, 2021
@syrusakbary syrusakbary added this to the v2.1 milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

@losfair losfair Awaiting requested review from losfair

Assignees

@syrusakbary syrusakbary

Labels
bug Something isn't working 📦 lib-compiler-singlepass About wasmer-compiler-singlepass
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@syrusakbary @Hywan