Base support for WASI in wasmer-js #2491

syrusakbary · 2021-07-24T06:11:24Z

This PR adds support for WASI targeting Javascript

commit b6245ddd19077015a974e9ffd28f164fedb87801 Author: Syrus Akbary <[email protected]> Date: Fri Jul 23 23:07:45 2021 -0700 Remove unused code commit 6bbf28c5c6d8c4603606e21af3190c52f41cbeb8 Author: Syrus Akbary <[email protected]> Date: Fri Jul 23 22:50:50 2021 -0700 Remove set_last_accessed, set_last_modified, set_created_time from the VirtualFs commit 999d6941c93f0ea8c8c803c7b1843ec90bd178b5 Author: Syrus Akbary <[email protected]> Date: Fri Jul 23 22:42:23 2021 -0700 Remove webc files commit 197b72a8978a2364145e20ebd6d44b5bd23082db Author: Syrus Akbary <[email protected]> Date: Fri Jul 23 22:38:29 2021 -0700 Revert "Wip updates for python webc" This reverts commit 2d3e013e64424c0a50f32f44ad0401680d31bf9d. # Conflicts: # Cargo.lock # lib/cli/Cargo.toml # lib/cli/src/commands/run.rs # lib/cli/src/commands/run/wasi.rs # lib/vfs/Cargo.toml # lib/wasi/Cargo.toml # lib/wasi/src/state/builder.rs # lib/wasi/src/state/mod.rs commit 83b7e3b1a1708ed34694e9a44902bd6d0617f0a4 Author: Syrus Akbary <[email protected]> Date: Fri Jul 23 22:34:36 2021 -0700 revert Remove webc commit 2de7f7f0ce518c74912509ef1fa4b7b1f00c4d11 Author: Syrus Akbary <[email protected]> Date: Fri Jul 23 22:31:05 2021 -0700 Improved testing commit 97075c5fa69fd2ef9192a4a9737400359e0ee37f Author: Syrus Akbary <[email protected]> Date: Fri Jul 23 22:06:08 2021 -0700 Improved bindings commit 9388790c2d31654701dd2925d30bfb35b158727c Author: Syrus Akbary <[email protected]> Date: Fri Jul 23 18:15:43 2021 -0700 Renamed virtual-fs to vfs commit 41d91328cd83d10c0fa7242fcfd731335bcd741e Merge: c0634645a 51fdf66 Author: Syrus Akbary <[email protected]> Date: Fri Jul 23 18:00:49 2021 -0700 Merge branch 'master' into js-api-wasi commit c0634645aebdf25fb545c63368114b531934970d Author: Syrus Akbary <[email protected]> Date: Fri Jul 23 15:06:08 2021 -0700 Fixed serde dependency commit 02def893ae24f2da279ed6d3b39b4e50c18ec708 Merge: f13e4c86d d3930be Author: Syrus Akbary <[email protected]> Date: Fri Jul 23 15:04:35 2021 -0700 Merge branch 'js-api' into js-api-wasi # Conflicts: # lib/wasi/Cargo.toml commit f13e4c86d48a0a527fa72270f29c9f8b97a6f820 Merge: f4ac010e1 fe04ea8 Author: Syrus Akbary <[email protected]> Date: Fri Jul 16 00:01:19 2021 -0700 Merge branch 'js-api' into js-api-wasi commit f4ac010e1ff33cd046474a500bb5b9e4604085f6 Author: Syrus Akbary <[email protected]> Date: Thu Jul 15 22:50:09 2021 -0700 Use latest resolver for namespace commit 505896a47c7d658cb4e39ab5256c9e960a2fedc6 Author: Syrus Akbary <[email protected]> Date: Thu Jul 15 22:49:48 2021 -0700 Updated WASI implementation commit 30470cb81248a388ea5cf27f1838aeb264dc8956 Author: Syrus Akbary <[email protected]> Date: Thu Jul 15 15:51:56 2021 -0700 Improved logging commit caf0c8289ad8ce2471558baab17adee4abc011f5 Author: Syrus Akbary <[email protected]> Date: Thu Jul 15 13:55:43 2021 -0700 Improved wasmer-js debugging commit 4e2278dafe8999c262a0cea5afd23f8ae895abcb Author: Syrus Akbary <[email protected]> Date: Thu Jul 15 08:29:35 2021 -0700 Added wasi tests commit 4f5c1fdbdae1f953498016c32d158038b6a6dc97 Author: Syrus Akbary <[email protected]> Date: Wed Jul 14 22:22:41 2021 -0700 Fixed build commit 692111d098b73229dbe722645b3d86ff6f5e4a5e Merge: 35dade1b1 7195a9c Author: Syrus Akbary <[email protected]> Date: Wed Jul 14 22:18:01 2021 -0700 Merge branch 'js-api' into js-api-wasi # Conflicts: # lib/js-api/src/trap.rs commit 35dade1b16f01ce67a23ba4fbfa25224dda1403e Author: Syrus Akbary <[email protected]> Date: Wed Jul 14 22:12:38 2021 -0700 Fixed wasi wast commit d3a6b42f8ebd790024c7631a87a295bd6957bb80 Author: Syrus Akbary <[email protected]> Date: Wed Jul 14 22:12:22 2021 -0700 Added extra instruction for wasmer-js commit 95b5c1ad005b17a3bacca45f906d717780f4f95a Author: Syrus Akbary <[email protected]> Date: Wed Jul 14 22:12:12 2021 -0700 Improved API to be resilient in and out js commit e4074de27bd4adcd9ee8e9e4973c2cfd5208d523 Author: Syrus Akbary <[email protected]> Date: Wed Jul 14 18:54:14 2021 -0700 Improved traps commit e512e06cc8c476a74eb9a8e381b0d4019cdc4365 Author: Syrus Akbary <[email protected]> Date: Wed Jul 14 18:31:30 2021 -0700 Improved WasiFs commit cc7bda3ae33a01336e79e0a6ca48e2a72eb0ad98 Merge: 0721bbfe0 8047e3e Author: Syrus Akbary <[email protected]> Date: Wed Jul 14 15:15:05 2021 -0700 Merge branch 'js-api' into js-api-wasi # Conflicts: # lib/js-api/Cargo.toml # lib/js-api/src/cell.rs # lib/js-api/src/env.rs # lib/js-api/src/export.rs # lib/js-api/src/exports.rs # lib/js-api/src/externals/function.rs # lib/js-api/src/externals/memory.rs # lib/js-api/src/externals/table.rs # lib/js-api/src/instance.rs # lib/js-api/src/lib.rs # lib/js-api/src/module.rs commit 0721bbfe04d8d3b54ddcfa66a60a3cb501631ac6 Merge: 8354e03f1 3604deb Author: Syrus Akbary <[email protected]> Date: Fri Jul 2 16:15:49 2021 -0700 Merge branch 'master' into js-api-wasi commit 8354e03f19b810f8fdaf0cadc3eb89bad30220ab Author: Syrus Akbary <[email protected]> Date: Fri Jul 2 10:25:27 2021 -0700 Improved sync commit bfa6db7e7201b46fd992361699141df501e6d13c Merge: 30aa8d4bb 7553efb Author: Syrus Akbary <[email protected]> Date: Fri Jul 2 10:07:23 2021 -0700 Merge branch 'features-cell' into js-api-wasi # Conflicts: # lib/api/src/ptr.rs commit 30aa8d4bb0115b3bb8275212d2f33327d32546e6 Author: Syrus Akbary <[email protected]> Date: Thu Jul 1 17:36:47 2021 -0700 Improved VirtualFS commit a72dc93d345ca2c4967a75a0e3ef5243ebe86f33 Author: Syrus Akbary <[email protected]> Date: Thu Jul 1 17:36:37 2021 -0700 Improved wasmer-js API commit 63c13f371f19103adb74a6f394c4c09d8fcc4d52 Author: Syrus Akbary <[email protected]> Date: Fri Jun 25 17:32:33 2021 -0700 Updated memory_fs commit a9e7206b7437984ac367351ea75bb14c8cafaf4d Merge: 6e7285af0 be5af68ef Author: Syrus Akbary <[email protected]> Date: Fri Jun 25 17:14:29 2021 -0700 Merge branch 'feature/webc' into js-api-wasi # Conflicts: # Cargo.lock # lib/cli/Cargo.toml # lib/virtual-fs/Cargo.toml # lib/wasi/Cargo.toml # lib/wasi/src/state/mod.rs commit 6e7285af02367a6431b302c17b708f8e0854be82 Author: Syrus Akbary <[email protected]> Date: Fri Jun 25 17:07:39 2021 -0700 Updated virtual fs deps commit 5eab9ac6f629ddb82f5e97c5fce37998fadf262d Author: Syrus Akbary <[email protected]> Date: Fri Jun 25 17:07:29 2021 -0700 Make wasi not serializable commit 1d242d4564e898d773601b87d135a8f5dc4a0f57 Author: Syrus Akbary <[email protected]> Date: Fri Jun 25 17:05:30 2021 -0700 Set WASI to use Strings instead of str commit 1d7cd64232e4bdd57b64d884d4d9b38dd68e1cdb Author: Syrus Akbary <[email protected]> Date: Fri Jun 25 17:03:23 2021 -0700 Improve Virtual FS commit 85f4bbe5ebc0e87138e74a43665616e96772ac5d Author: Syrus Akbary <[email protected]> Date: Fri Jun 25 16:57:14 2021 -0700 wasmer-js: Added functions to the mix commit 27effe1eda37a1d810a80a489ff5c737e986f200 Author: Syrus Akbary <[email protected]> Date: Fri Jun 25 16:01:12 2021 -0700 wasmer-js function environments working commit be5af68efe44c5084dd140f9cc6b425f61a84f8a Author: Mark McCaskey <[email protected]> Date: Fri Jun 25 15:01:18 2021 -0700 Move webc vfs impl into wasmer src tree commit 765c89bb3954699b86a2b820fd40857811e6c466 Author: Mark McCaskey <[email protected]> Date: Fri Jun 25 14:38:19 2021 -0700 Get python.webc working commit bedc25cbf00a91cca193bb21834117dc3344febe Author: Syrus Akbary <[email protected]> Date: Fri Jun 25 09:17:26 2021 -0700 wasmer-js improve get_host_environment commit ee3a36d53b06be72dc00877332c4aaf0b2f57aa4 Author: Syrus Akbary <[email protected]> Date: Thu Jun 24 19:37:34 2021 -0700 Added wasm32 API commit c136c2ac6829e4ac3d916dc5687a7c999dd6c412 Author: Syrus Akbary <[email protected]> Date: Thu Jun 24 18:56:19 2021 -0700 Improved wasmer_js API commit f819cbbb629442f6f020985ca34b2b57bc90deca Author: Syrus Akbary <[email protected]> Date: Thu Jun 24 18:32:29 2021 -0700 Improved wasmer_js imports commit 1d4ed08d90808922ee5e74e92f162509ba8c2efb Merge: 5451d71 2d3e013e6 Author: Syrus Akbary <[email protected]> Date: Thu Jun 24 17:55:25 2021 -0700 Merge branch 'feature/webc' into js-api-wasi # Conflicts: # lib/wasi/src/syscalls/mod.rs commit 2d3e013e64424c0a50f32f44ad0401680d31bf9d Author: Mark McCaskey <[email protected]> Date: Thu Jun 24 16:54:43 2021 -0700 Wip updates for python webc commit 3a5a687964780d48e8598247009721badd50d496 Author: Mark McCaskey <[email protected]> Date: Wed Jun 23 10:36:06 2021 -0700 Add patch to get vfs

syrusakbary · 2021-07-25T20:06:39Z

bors try

bors · 2021-07-25T20:11:34Z

try

Build failed:

Test on windows-x64

syrusakbary · 2021-07-27T03:28:45Z

bors try

bors · 2021-07-27T03:32:10Z

try

Build failed:

Code lint

syrusakbary · 2021-07-27T03:45:40Z

bors try

bors · 2021-07-27T03:50:17Z

try

Build failed:

Test on windows-x64

syrusakbary · 2021-07-27T04:02:55Z

bors try

bors · 2021-08-30T13:50:19Z

try

Build failed:

Code lint

This reverts commit 347f4c6.

…mError`.

lib/types/src/memory_view.rs

lib/wasi/src/state/builder.rs

Hywan · 2021-08-30T15:05:41Z

lib/wasi/src/state/mod.rs

+        todo!("temporarily disabled")
+        //bincode::serialize(self).ok()


Why? cc @syrusakbary

We can revert and make bincode an optional dependency if enable-serde feature is set

lib/wasi/src/syscalls/mod.rs

Hywan · 2021-08-30T15:08:57Z

bors try

lib/wasi/src/state/mod.rs

bors · 2021-08-30T16:10:00Z

try

Build succeeded:

…l state.

Hywan · 2021-08-31T07:55:30Z

I'm not fully satisfied with the state of this PR, but it's way better than it was initially. Let's fix the other pain points in other PR.

bors r+

2491: Base support for WASI in wasmer-js r=Hywan a=syrusakbary This PR adds support for WASI targeting Javascript Co-authored-by: Syrus Akbary <[email protected]> Co-authored-by: Ivan Enderlin <[email protected]>

Hywan · 2021-08-31T07:56:45Z

bors r-

bors · 2021-08-31T07:56:46Z

Canceled.

Hywan · 2021-08-31T07:57:06Z

bors r+

bors · 2021-08-31T08:47:05Z

Build succeeded:

syrusakbary requested review from Hywan, jubianchi and MarkMcCaskey as code owners July 24, 2021 06:11

syrusakbary added 10 commits July 23, 2021 23:16

Removed unnecessary comments

65dacb5

Fix format

2e9cc52

Commented unused code

58bd122

Get serializer back into working

576312e

Improved default fs backing

fb616cf

Make WASI serialization optional

e79b8a0

Removed all warnings

b2b576f

Fixed most TODOs

f15f9de

Remove WASI rename_file default implementation

c810940

Fix compilation

1855700

bors bot added a commit that referenced this pull request Jul 25, 2021

Try #2491:

e58385a

syrusakbary added 2 commits July 26, 2021 20:26

Improved logging for tests

876eefe

Moved rename_file to the filesystem. Fix fs readdir

75340e1

bors bot added a commit that referenced this pull request Jul 27, 2021

Try #2491:

efa0bc7

syrusakbary added 2 commits July 26, 2021 20:40

Fix compilation/linting issues

616d199

Ignore some tests for now

cc6013c

bors bot added a commit that referenced this pull request Jul 27, 2021

Try #2491:

e2470d1

syrusakbary added 2 commits July 26, 2021 20:51

Fix compilation in windows

55ff142

Fixed tests

d371fd2

Hywan added 8 commits August 30, 2021 15:56

fix(vfs) Fix 4f59083.

d0a95ac

chore(vfs) Remove Clippy warnings.

bb47a47

fix(api) Remove the temporary Memory::uint8 method.

347f4c6

fix(cli) Simplify a pattern matching.

5ae6b98

Revert "fix(api) Remove the temporary Memory::uint8 method."

eb19c98

This reverts commit 347f4c6.

doc(api) Document that Memory::uint8view is going to be refactored.

2ff9838

chore(types) Remove commented code.

a4525e0

feat(wasi) Update WasiStateCreationgError::FsError to `…::FileSyste…

768eb5c

…mError`.

Hywan reviewed Aug 30, 2021

View reviewed changes

bors bot added a commit that referenced this pull request Aug 30, 2021

Try #2491:

86ee1e3

feat(wasi) Clean commented code.

650352d

syrusakbary commented Aug 30, 2021

View reviewed changes

lib/wasi/src/state/mod.rs Outdated Show resolved Hide resolved

feat(vfs) mem-fs does not support enable-serde.

87558a9

Hywan added 2 commits August 31, 2021 09:46

doc(wasi) Document that WasiStateBuilder::build is changing interna…

4eaa864

…l state.

feat(wasi) Provide WasiState::(un)freeze if enable-serde is enabled.

a12ec28

Hywan approved these changes Aug 31, 2021

View reviewed changes

chore(cargo) Update Cargo.lock.

c28499e

bors bot merged commit a57a852 into master Aug 31, 2021

bors bot deleted the js-api-wasi branch August 31, 2021 08:47

syrusakbary mentioned this pull request Oct 28, 2021

Abstracted WASI FS #2412

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Base support for WASI in wasmer-js #2491

Base support for WASI in wasmer-js #2491

syrusakbary commented Jul 24, 2021

syrusakbary commented Jul 25, 2021

bors bot commented Jul 25, 2021

syrusakbary commented Jul 27, 2021

bors bot commented Jul 27, 2021

syrusakbary commented Jul 27, 2021

bors bot commented Jul 27, 2021

syrusakbary commented Jul 27, 2021

bors bot commented Aug 30, 2021

Hywan Aug 30, 2021

syrusakbary Aug 30, 2021

Hywan commented Aug 30, 2021

bors bot commented Aug 30, 2021

Hywan commented Aug 31, 2021

Hywan commented Aug 31, 2021

bors bot commented Aug 31, 2021

Hywan commented Aug 31, 2021

bors bot commented Aug 31, 2021

		todo!("temporarily disabled")
		//bincode::serialize(self).ok()

Base support for WASI in wasmer-js #2491

Base support for WASI in wasmer-js #2491

Conversation

syrusakbary commented Jul 24, 2021

syrusakbary commented Jul 25, 2021

bors bot commented Jul 25, 2021

try

syrusakbary commented Jul 27, 2021

bors bot commented Jul 27, 2021

try

syrusakbary commented Jul 27, 2021

bors bot commented Jul 27, 2021

try

syrusakbary commented Jul 27, 2021

bors bot commented Aug 30, 2021

try

Hywan Aug 30, 2021

Choose a reason for hiding this comment

syrusakbary Aug 30, 2021

Choose a reason for hiding this comment

Hywan commented Aug 30, 2021

bors bot commented Aug 30, 2021

try

Hywan commented Aug 31, 2021

Hywan commented Aug 31, 2021

bors bot commented Aug 31, 2021

Hywan commented Aug 31, 2021

bors bot commented Aug 31, 2021