Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on wasmer validate if the provided file is not wasm. Fix #2477 #2479

Merged
merged 1 commit into from
Jul 18, 2021
Merged

Error on wasmer validate if the provided file is not wasm. Fix #2477 #2479

merged 1 commit into from
Jul 18, 2021

Conversation

syrusakbary
Copy link
Member

Description

Error on wasmer validate if the provided file is not wasm. Fix #2477

Review

  • Add a short description of the change to the CHANGELOG.md file

Hywan
Hywan approved these changes Jul 18, 2021
View reviewed changes
Copy link
Contributor

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Hywan Hywan self-assigned this Jul 18, 2021
@Hywan Hywan added 📦 lib-cli About wasmer-cli 🎉 enhancement New feature! labels Jul 18, 2021
@Hywan
Copy link
Contributor

Hywan commented Jul 18, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 18, 2021

Build succeeded:

@bors bors bot merged commit 436c82a into master Jul 18, 2021
@bors bors bot deleted the validate-wasm branch July 18, 2021 20:15
@syrusakbary syrusakbary added this to the v2.1 milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan approved these changes

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

Assignees

@Hywan Hywan

Labels
🎉 enhancement New feature! 📦 lib-cli About wasmer-cli
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.

wasmer tool can successfully produce compiled binaries that do not pass validation checks
2 participants
@syrusakbary @Hywan