Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(compiler) Remove ModuleInfoTranslate #2476

Merged
merged 1 commit into from
Jul 20, 2021
Merged

chore(compiler) Remove ModuleInfoTranslate #2476

merged 1 commit into from
Jul 20, 2021

Conversation

syrusakbary
Copy link
Member

Description

After #2460, I realized there can be some code that is simplified.

Review

  • Add a short description of the change to the CHANGELOG.md file

Hywan
Hywan reviewed Jul 19, 2021
View reviewed changes
Copy link
Contributor

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

It removes ModuleInfoTranslation and updates the code accordingly. Can you justify why ModuleInfoTranslate is no longer required please :-)?

@Hywan
Copy link
Contributor

Hywan commented Jul 19, 2021

And please, update the CHANGELOG.

@Hywan Hywan self-assigned this Jul 19, 2021
@Hywan Hywan added 🎉 enhancement New feature! 📦 lib-compiler About wasmer-compiler labels Jul 19, 2021
@syrusakbary
Copy link
Member Author

Can you justify why ModuleInfoTranslate is no longer required please :-)?

ModuleInfoTranslate is an abstraction that is unnecessary and not used anywhere outside of the crate.
It was only necessary because an extra field is not really needed at all. This PR simplifies the code

Hywan
Hywan approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@Hywan Hywan changed the title Simplified Compiler chore(compiler) Remove ModuleInfoTranslate Jul 20, 2021
@bors
Copy link
Contributor

bors bot commented Jul 20, 2021

Build succeeded:

@bors bors bot merged commit da57091 into master Jul 20, 2021
@bors bors bot deleted the compiler-improvement branch July 20, 2021 13:27
@syrusakbary syrusakbary added this to the v2.1 milestone Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan approved these changes

@losfair losfair Awaiting requested review from losfair

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

Assignees

@Hywan Hywan

Labels
🎉 enhancement New feature! 📦 lib-compiler About wasmer-compiler
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@syrusakbary @Hywan