Remove FuncRef registry - WIP #2437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are failing, running here to show what is failing: bors try |
tryBuild failed: |
|
I'm not sure if this is helpful but I'm seeing very high cpu usage in our application when using wasmer 2.0 and I did a flamegraph. It seems like there is a lock in the |
|
Thanks for the report @freesig |
|
@freesig Thanks! That is very useful to know. Can you provide some more info about your usage pattern? Are you instantiating modules on multiple threads? This PR should fix that because it removes the lock and FuncDataRegistry |
|
Yep definitely instantiating on different threads |
|
bors try |
tryMerge conflict. |
syrusakbary
added
the
🕵️ needs investigation
# Conflicts: # lib/engine-dylib/src/artifact.rs # lib/engine-staticlib/src/artifact.rs # lib/engine-universal/src/artifact.rs # lib/engine-universal/src/engine.rs # lib/engine/src/artifact.rs # tests/lib/engine-dummy/src/artifact.rs
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
matklad
pushed a commit
to matklad/wasmer
that referenced
this pull request
Nov 1, 2021
This backports wasmerio/wasmer#2437 to fix wasmerio/wasmer#2638 On a high-level, Store (global state for the whole wasmer runtime) used to store pointers to host functions. This was a partial implementation of the module linking proposal: for that, we need to be able to use functions *across* several instances, so we need to keep such functions in some sort of global state. This commit moves the data to the Instance. This breaks some module linking related tests, but we are not using that, and the support wasn't complete anyway. Note that the actual memory management remains the same: `Instance::imported_function_envs` is the thing that was and still is responsible for dropping data related to external functions.
matklad
pushed a commit
to matklad/wasmer
that referenced
this pull request
Nov 1, 2021
This backports wasmerio/wasmer#2437 to fix wasmerio/wasmer#2638 On a high-level, Store (global state for the whole wasmer runtime) used to store pointers to host functions. This was a partial implementation of the module linking proposal: for that, we need to be able to use functions *across* several instances, so we need to keep such functions in some sort of global state. This commit moves the data to the Instance. This breaks some module linking related tests, but we are not using that, and the support wasn't complete anyway. Note that the actual memory management remains the same: `Instance::imported_function_envs` is the thing that was and still is responsible for dropping data related to external functions.
|
Closing in favor of #2699 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermediate fix for funcref lifetimes:
Review