Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(middlewares) Add more examples and more doctests #2402

Merged
merged 4 commits into from
Jun 7, 2021

Conversation

Hywan
Copy link
Contributor

@Hywan Hywan commented Jun 7, 2021

Description

The idea of this patch is to improve the documentation of the
wasmer-middlewares crate by doing the following:

  • Link to the fully detailed existing metering example,
  • Give an overview of how to push a middleware on a compiler,
  • Give one example per type and function: Metering,
    MeteringPoints, get_remaining_points and set_remaining_points.

Review

  • Add a short description of the change to the CHANGELOG.md file

Hywan added 2 commits June 7, 2021 14:57
The idea of this patch is to improve the documentation of the
`wasmer-middlewares` crate by doing the following:

* Link to the fully detailed existing `metering` example,
* Give an overview of how to push a middleware on a compiler,
* Give one example per type and function: `Metering`,
  `MeteringPoints`, `get_remaining_points` and `set_remaining_points`.
@Hywan Hywan added 🎉 enhancement New feature! 🧪 tests I love tests 📚 documentation Do you like to read? labels Jun 7, 2021
@Hywan Hywan requested review from jubianchi and MarkMcCaskey June 7, 2021 13:11
@Hywan Hywan self-assigned this Jun 7, 2021
@Hywan Hywan added the 📦 lib-middlewares About wasmer-middlewares label Jun 7, 2021
@syrusakbary syrusakbary merged commit 0ca884d into wasmerio:master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Do you like to read? 🎉 enhancement New feature! 📦 lib-middlewares About wasmer-middlewares 🧪 tests I love tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants