Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Singlepass issue #2347 #2391

Merged
merged 5 commits into from
Jun 15, 2021
Merged

Fix Singlepass issue #2347 #2391

merged 5 commits into from
Jun 15, 2021

Conversation

chenyukang
Copy link
Contributor

@chenyukang chenyukang commented Jun 5, 2021 •
edited by Hywan
Loading

Description

Fix Singlepass compiler issue: #2347

I'm not sure whether the unit test case added to a suitable file.
Any better suggestion?
@syrusakbary

Edit by @Hywan: Close #2347, close #2159.

@chenyukang
Copy link
Contributor Author

Issue #2159 is the same bug.

Hywan
Hywan reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@Hywan Hywan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

I believe the best place to write those unit tests (the one your wrote, and the one from #2159) is in tests/wast/wasmer/. Is it OK for you to do it?

Also please, do not forget to update the CHANGELOG.md file :-).

@Hywan Hywan self-assigned this Jun 7, 2021
@Hywan Hywan added bug Something isn't working 📦 lib-compiler-singlepass About wasmer-compiler-singlepass labels Jun 7, 2021
@chenyukang
Copy link
Contributor Author

Looks good to me! Thanks!

I believe the best place to write those unit tests (the one your wrote, and the one from #2159) is in tests/wast/wasmer/. Is it OK for you to do it?

Also please, do not forget to update the CHANGELOG.md file :-).

Ok, I will update it.

@chenyukang
Copy link
Contributor Author

@Hywan Done!

Hywan
Hywan reviewed Jun 7, 2021
View reviewed changes
Copy link
Contributor

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rename the following files:

  • tests/wast/wasmer/nan-canonicalization-bug1.wast to tests/…/issue-2347.wast
  • tests/wast/wasmer/nan-canonicalization-bug2.wast to tests/…/issue-2159.wast

please :-)?

And then we are good!

@chenyukang
Copy link
Contributor Author

Can you please rename the following files:

  • tests/wast/wasmer/nan-canonicalization-bug1.wast to tests/…/issue-2347.wast
  • tests/wast/wasmer/nan-canonicalization-bug2.wast to tests/…/issue-2159.wast

please :-)?

And then we are good!

No, we must keep the name with nan-canonicalization, because the logic here:
https://github.com/wasmerio/wasmer/blob/master/tests/compilers/wast.rs#L19

This bug is only triggered when try_nan_canonicalization is true...

@syrusakbary
Copy link
Member

Good catch @chenyukang!

Can we have then this names instead?

  • tests/wast/wasmer/nan-canonicalization-issue-2347
  • tests/wast/wasmer/nan-canonicalization-issue-2159

Thanks!

@chenyukang
Copy link
Contributor Author

  • tests/wast/wasmer/nan-canonicalization-issue-2159

Done！

Hywan
Hywan approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@Hywan Hywan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Jun 8, 2021
@bors @chenyukang
Merge #2391
7910f78 
2391: Fix Singlepass issue #2347 r=Hywan a=chenyukang

# Description
Fix Singlepass compiler issue: #2347 

I'm not sure whether the unit test case added to a suitable file. 
Any better suggestion?
@syrusakbary 

Edit by @Hywan: Close #2347, close #2159.


Co-authored-by: yukang <[email protected]>
Co-authored-by: Yukang <[email protected]>
@syrusakbary
Copy link
Member

Just realized that we might want further review on this PR.
We should be able to merge soon though!

bors r-

@bors
Copy link
Contributor

bors bot commented Jun 8, 2021

Canceled.

@syrusakbary
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 15, 2021

Build succeeded:

@bors bors bot merged commit e6c8fcd into wasmerio:master Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hywan Hywan Hywan approved these changes

@losfair losfair Awaiting requested review from losfair

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

Assignees

@Hywan Hywan

Labels
bug Something isn't working 📦 lib-compiler-singlepass About wasmer-compiler-singlepass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in the singlepass compiler singlepass crashes compiling fdiv + fcopysign
3 participants
@chenyukang @syrusakbary @Hywan